New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive yield of nails from cabin rubble #26162

Open
boydkr opened this Issue Oct 10, 2018 · 7 comments

Comments

Projects
None yet
6 participants
@boydkr
Contributor

boydkr commented Oct 10, 2018

Describe the bug
A collapse porch and corner of a cabin in the woods yielded almost 9000 nails.

To Reproduce
Steps to reproduce the behavior:

  1. Find cabin innawoods
  2. Look for rubble
  3. clear rubble

Expected behavior
I would expect there to be maybe a few hundred nails, in the rubble

Screenshots
excessive_nails

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version: 0.C-33196-g90d0a9b
  • Graphics version: Tiles
  • Mods loaded: Makeshift items, more survival tools, extended buildings
@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 11, 2018

Member
Member

kevingranade commented Oct 11, 2018

@Xion350

This comment has been minimized.

Show comment
Hide comment
@Xion350

Xion350 Oct 11, 2018

That assumes that most of the nails are usable. Which I highly doubt they would be after being used in construction and torn apart.

Xion350 commented Oct 11, 2018

That assumes that most of the nails are usable. Which I highly doubt they would be after being used in construction and torn apart.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 11, 2018

Member

Eh, you can straighten and re-use nails, it wastes a bit of time, but I don't think enough time for us to track it.

Member

kevingranade commented Oct 11, 2018

Eh, you can straighten and re-use nails, it wastes a bit of time, but I don't think enough time for us to track it.

@Rivet-the-Zombie

This comment has been minimized.

Show comment
Hide comment
@Rivet-the-Zombie

Rivet-the-Zombie Oct 12, 2018

Member

I'd expect the heat of the fire to ruin some of the nails' temper, rendering a great many of them too soft to effectively reuse for their intended purpose.

Member

Rivet-the-Zombie commented Oct 12, 2018

I'd expect the heat of the fire to ruin some of the nails' temper, rendering a great many of them too soft to effectively reuse for their intended purpose.

@FulcrumA

This comment has been minimized.

Show comment
Hide comment
@FulcrumA

FulcrumA Oct 12, 2018

Contributor

I am really ambivalent toward the whole thing. In many cases it'd require a really strong fire to render a nail completely unsuitable rather than just somewhat less dependable while still useful. If we also count loss of nails from walls and ceiling as how @kevingranade mentions, the number of usable ones that can be retrieved doesn't strike me as so weird. IRL the biggest issue likely wouldn't be number of nails that could be retrieved from a fire, but having to look through the rubble to retrieve them.

I guess to not have to track quality of every nail, one could code it in a way that "raging fire" on a tile would have a chance to damage nails as well if maintained long enough (ensuring fire temperature above resistance of iron material?) but it probably shouldn't go beyond that.

Contributor

FulcrumA commented Oct 12, 2018

I am really ambivalent toward the whole thing. In many cases it'd require a really strong fire to render a nail completely unsuitable rather than just somewhat less dependable while still useful. If we also count loss of nails from walls and ceiling as how @kevingranade mentions, the number of usable ones that can be retrieved doesn't strike me as so weird. IRL the biggest issue likely wouldn't be number of nails that could be retrieved from a fire, but having to look through the rubble to retrieve them.

I guess to not have to track quality of every nail, one could code it in a way that "raging fire" on a tile would have a chance to damage nails as well if maintained long enough (ensuring fire temperature above resistance of iron material?) but it probably shouldn't go beyond that.

@boydkr

This comment has been minimized.

Show comment
Hide comment
@boydkr

boydkr Oct 12, 2018

Contributor

I think the issue is that the nails are somehow being added by count instead of by charges:

https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/map.cpp#L2409

It's supposed to add_item_or_charges, but that doesn't appear to be what is happening

Contributor

boydkr commented Oct 12, 2018

I think the issue is that the nails are somehow being added by count instead of by charges:

https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/map.cpp#L2409

It's supposed to add_item_or_charges, but that doesn't appear to be what is happening

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 12, 2018

Member

yea the retrieval rate is a bit of a side-track, it looks like it's dropping hundreds of nails per tile instead of dozens.

Member

kevingranade commented Oct 12, 2018

yea the retrieval rate is a bit of a side-track, it looks like it's dropping hundreds of nails per tile instead of dozens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment