New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacuum Sealer makes rotten things fresh #26186

Open
EirenexTheDragon opened this Issue Oct 11, 2018 · 5 comments

Comments

@EirenexTheDragon
Contributor

EirenexTheDragon commented Oct 11, 2018

Describe the bug
Using the recipee to make vacuum fruit slices and using rotten fruit as ingredient causes the end product to become a fresh nonrotten product that you can safely eat.

To Reproduce
Steps to reproduce the behavior:

  1. Obtain Vacuum sealer, ingredients for the vacuum products and the rotten fruit
  2. craft Vacuum fruit slices
  3. activate the vacuumed fruit slices to notice how it is fresh now.

Expected behavior
It should come out as rotten. sucking the air out of things doesnt just removes it from being rotten

Screenshots
If applicable, add screenshots to help explain your problem.

Versions and configuration(please complete the following information):

  • OS: Windows 7
  • Game Version O.C-33196-g90d0a9b (close to most current version in short)
  • Graphics version does not matter.
  • Mods loaded Statsthroughskills, manual bionic installation, safe autodoc, no fungal mon, boats, folding parts pack, vehicle additions pack, tanks and other vehicles, Fuji's more buildings. more locations, Mutant NPCs, Hair aka rainbow, npc traits, alternative map key, extended realistic guns, more survival tools, medieval and historic content, makeshift items mod, filthy clothing, disable npc needs

Additional context
This issue would probably affect the vacuum recipes of meat, veggy and fish aswell, but i only tested with rotten fruit.

@FulcrumA

This comment has been minimized.

Show comment
Hide comment
@FulcrumA

FulcrumA Oct 11, 2018

Contributor

An old bug, already in a number of tickets. It's not even just making things that spoil that refreshes certain ingredients but for example, dehydrated meat is perfectly fine when made from rotten. I think it'd be fine if certain recipes wouldn't care about status of the ingredients, but certainly not all.

Contributor

FulcrumA commented Oct 11, 2018

An old bug, already in a number of tickets. It's not even just making things that spoil that refreshes certain ingredients but for example, dehydrated meat is perfectly fine when made from rotten. I think it'd be fine if certain recipes wouldn't care about status of the ingredients, but certainly not all.

@EirenexTheDragon

This comment has been minimized.

Show comment
Hide comment
@EirenexTheDragon

EirenexTheDragon Oct 11, 2018

Contributor

why not make it work like the canned food recipes? which has a (special) plastic container that actually prevents spoiling? that would solve it and spit it out as rotten if its truly rotten

Contributor

EirenexTheDragon commented Oct 11, 2018

why not make it work like the canned food recipes? which has a (special) plastic container that actually prevents spoiling? that would solve it and spit it out as rotten if its truly rotten

@alanbrady

This comment has been minimized.

Show comment
Hide comment
@alanbrady

alanbrady Oct 11, 2018

Contributor

Hrm I'm pretty sure there's an easy fix.

if( newit.goes_bad() ) {

Here we only set relative rot if it goes bad. I think if that changed to if( newit.is_food() ) { it'll do the right thing. I'm not 100% how that will work with items that don't have a spoil timer though, it might just break horribly or it might just work majestically.

Contributor

alanbrady commented Oct 11, 2018

Hrm I'm pretty sure there's an easy fix.

if( newit.goes_bad() ) {

Here we only set relative rot if it goes bad. I think if that changed to if( newit.is_food() ) { it'll do the right thing. I'm not 100% how that will work with items that don't have a spoil timer though, it might just break horribly or it might just work majestically.

@nexusmrsep

This comment has been minimized.

Show comment
Hide comment
@nexusmrsep

nexusmrsep Oct 12, 2018

Contributor

I'm not 100% how that will work with items that don't have a spoil timer though, it might just break horribly or it might just work majestically.

For what I know it would result in some level of rot (or even complete rot), that would not move forward, since the non-perishables still have the rot variable to work with, but the rot 'tick' is prevented. I think its safe to do it that way.

Contributor

nexusmrsep commented Oct 12, 2018

I'm not 100% how that will work with items that don't have a spoil timer though, it might just break horribly or it might just work majestically.

For what I know it would result in some level of rot (or even complete rot), that would not move forward, since the non-perishables still have the rot variable to work with, but the rot 'tick' is prevented. I think its safe to do it that way.

@ZhilkinSerg ZhilkinSerg added this to Need Confirmation in 0.D Release via automation Oct 14, 2018

@ZhilkinSerg ZhilkinSerg added this to the 0.D milestone Oct 14, 2018

@mlangsdorf mlangsdorf moved this from Need Confirmation to Confirmed in 0.D Release Oct 15, 2018

@rubenpd

This comment has been minimized.

Show comment
Hide comment
@rubenpd

rubenpd Oct 15, 2018

tin cans and sealed glass jars of food/drinks has same problem, transforms rotten meat/whatever ingredient from rotten into 100%fresh

rubenpd commented Oct 15, 2018

tin cans and sealed glass jars of food/drinks has same problem, transforms rotten meat/whatever ingredient from rotten into 100%fresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment