Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-localized build: Lots of displayed format strings #2639

Closed
1942rob opened this issue Aug 24, 2013 · 7 comments

Comments

Projects
None yet
4 participants
@1942rob
Copy link
Contributor

commented Aug 24, 2013

like "$c: $s", "$s batter $s for 20 damage", and so on

@utunnels

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2013

It appears those printf functions need to be rewritten, or that part of code.

@yobbobanana

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2013

I can't reproduce this, it all works fine for me even with the nonlocalized build. I can't see why it would fail either.

It looks like all the strings that cause problems are the ones with numbered parameters. So for example if you put something in a vehicle's trunk it uses "You put your %1$s in the %2$s's %3$s.", which i assume comes out as "You put your $s in the $s's $s."?

@kevingranade

This comment has been minimized.

Copy link
Member

commented Aug 27, 2013

Oh, I think I heard about this somewhere, windows printf implementation not
handling that kind of format string or something.

@ghost

This comment has been minimized.

Copy link

commented Oct 1, 2013

I've also encountered this problem. Is there any info I could provide which would help?

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 9, 2013

I think we just need to pull the special escaping out of the un-translated strings, since we don't actually need them there.

@yobbobanana

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2013

Alias _() to a function that strips out the 1$, 2$ etc for the nonlocalized build? I think that would work.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 10, 2013

Genius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.