Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SomeDeadGuy's Xotto tileset to build #26676

Closed
rainbowjose opened this issue Nov 13, 2018 · 14 comments

Comments

Projects
None yet
6 participants
@Lorith

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

Should ask him to put in a pull request to attempt adding it, but it would be slower to update, as currently he can update it at any point in time, and would also significantly increase file size.

@rainbowjose

This comment has been minimized.

Copy link
Contributor Author

commented Nov 13, 2018

Should ask him to put in a pull request to attempt adding it, but it would be slower to update, as currently he can update it at any point in time, and would also significantly increase file size.

But this tileset is really worth.

@Lorith

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

I agree, but it is his choice if he wants to try to have it added or not. Ask him to put in a pull request and it can be considered by the folks who can merge things.

@Leland

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

Pinging @SomeDeadGuy

Note: Renamed issue to help with visibility

@Leland Leland changed the title Add best tileset to build Add SomeDeadGuy's Xotto tileset to build Nov 14, 2018

@SomeDeadGuy

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

Wait, let me think about it... NO.
I will only have disadvantages if i will merge with main frame.

@rainbowjose

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

Disadvantages for you? I think community can handle maintaining of this tileset, isn't? People asking you only for permit to use your work in the build.

@Lorith

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

Every update would require going through a number of people to verify, have to worry about possible issues with the team over content on multiple levels, slower update speed, and numerous other issues. He said no, so it probably won't be going in unless he changes his mind.

@rainbowjose

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

Every update would require going through a number of people to verify, have to worry about possible issues with the team over content on multiple levels, slower update speed, and numerous other issues. He said no, so it probably won't be going in unless he changes his mind.

But theres so much shitty tilesets present in build now, some of them outdated. And here a really high-quality tileset, which someone will probably support, and the author himself has not yet abandoned him at all, he simply does not like all this red tape. Put it in build and leave it as it is. If some kind of tileset is needed there, then obviously this one.

Why this https://i.imgur.com/8oxsXar.png is in the build, and this https://i.imgur.com/akh8zen.png is not?

@SomeDeadGuy

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

raibowjose you do not have to ask me for permissions, my tileset is free and can be taken by anyone and be edited or added to mainframe if they want it
Just call it something other then MSX_DeadPeople (MSX_AlivePeople?) so people would not confuse the two. Cause my still going to be better. :P

@rainbowjose

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

raibowjose you do not have to ask me for permissions, my tileset is free and can be taken by anyone and be edited or added to mainframe if they want it
Just call it something other then MSX_DeadPeople (MSX_AlivePeople?) so people would not confuse the two. Cause my still going to be better. :P

Okay.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

We should have some infrastructure to store and retrieve tilesets from some network locations - that would make tileset maintenance easier. It is more a work for a launcher and it is a planned version there https://github.com/remyroy/CDDA-Game-Launcher/blob/master/README.md

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

Also we can have barebone tileset in the main repo with only basic tiles (e.g fallback.png) and all the other tiles bundled through tileset mod which is not in the main repo -
#25633 (which already could be managed by launcher).

@AMurkin

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

For that we need crossplatform launcher first.

@Leland

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

Closing – per the author, feel free to open up a PR with the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.