Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd SomeDeadGuy's Xotto tileset to build #26676
Comments
This comment has been minimized.
This comment has been minimized.
|
Should ask him to put in a pull request to attempt adding it, but it would be slower to update, as currently he can update it at any point in time, and would also significantly increase file size. |
This comment has been minimized.
This comment has been minimized.
But this tileset is really worth. |
This comment has been minimized.
This comment has been minimized.
|
I agree, but it is his choice if he wants to try to have it added or not. Ask him to put in a pull request and it can be considered by the folks who can merge things. |
Leland
added
<Suggestion / Discussion>
SDL: Tiles / Sound
labels
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Pinging @SomeDeadGuy Note: Renamed issue to help with visibility |
Leland
changed the title
Add best tileset to build
Add SomeDeadGuy's Xotto tileset to build
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Wait, let me think about it... NO. |
This comment has been minimized.
This comment has been minimized.
|
Disadvantages for you? I think community can handle maintaining of this tileset, isn't? People asking you only for permit to use your work in the build. |
This comment has been minimized.
This comment has been minimized.
|
Every update would require going through a number of people to verify, have to worry about possible issues with the team over content on multiple levels, slower update speed, and numerous other issues. He said no, so it probably won't be going in unless he changes his mind. |
This comment has been minimized.
This comment has been minimized.
But theres so much shitty tilesets present in build now, some of them outdated. And here a really high-quality tileset, which someone will probably support, and the author himself has not yet abandoned him at all, he simply does not like all this red tape. Put it in build and leave it as it is. If some kind of tileset is needed there, then obviously this one. Why this https://i.imgur.com/8oxsXar.png is in the build, and this https://i.imgur.com/akh8zen.png is not? |
This comment has been minimized.
This comment has been minimized.
|
raibowjose you do not have to ask me for permissions, my tileset is free and can be taken by anyone and be edited or added to mainframe if they want it |
This comment has been minimized.
This comment has been minimized.
Okay. |
This comment has been minimized.
This comment has been minimized.
|
We should have some infrastructure to store and retrieve tilesets from some network locations - that would make tileset maintenance easier. It is more a work for a launcher and it is a planned version there https://github.com/remyroy/CDDA-Game-Launcher/blob/master/README.md |
This comment has been minimized.
This comment has been minimized.
|
Also we can have barebone tileset in the main repo with only basic tiles (e.g fallback.png) and all the other tiles bundled through tileset mod which is not in the main repo - |
This comment has been minimized.
This comment has been minimized.
|
For that we need crossplatform launcher first. |
This comment has been minimized.
This comment has been minimized.
|
Closing – per the author, feel free to open up a PR with the changes |
rainbowjose commentedNov 13, 2018
https://i.imgur.com/PNNQ8T3.png
https://github.com/SomeDeadGuy/Cata-MSX-DeadPeopleTileset