Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory Key Duplication with Stack Split #2672

Closed
Sarge-101 opened this issue Aug 26, 2013 · 2 comments

Comments

Assignees
No one assigned
Labels
<Bug>
Projects
None yet
Milestone
  0.8
3 participants
@Sarge-101 @yobbobanana @kevingranade
@Sarge-101
Copy link

commented Aug 26, 2013

I made 5 x lockpicks and the were batched together. When using it, it took damage but the entire stack all stayed in the same stack still. It took another damage hit and then the stack split, but the inventory key allocation was duplicated.

http://i.imgur.com/qniUwUA.jpg

CIB added a commit to CIB/Cataclysm-DDA that referenced this issue Sep 10, 2013

@CIB
Add a missing case for invlet reshuffling on force invlet assignment. 
Fixes issue CleverRaven#2672

There's a tiny other change in there, which is to remove a duplicate call of update_cache_with_item(). The call is unnecessary if reuse_cached_letter is false, and if it's true, the call will be made anyway.
2f74fbc

@CIB CIB referenced this issue Sep 10, 2013

Merged

Add a missing case for invlet reshuffling on force invlet assignment. #2945

@yobbobanana

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 14, 2013

Can't reproduce (i could a little while ago), so maybe fixed?
@kevingranade

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 14, 2013

Yea this one in particular is definitely fixed.

@kevingranade kevingranade closed this Sep 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.