Item health not shown

[gcaliber]

Item health bars/damaged status text not shown.

• OS: Manjaro Linux 4.19.13-1-MANJARO
• Game Version: 0.C-36489-g3cec9b8c91
• Graphics version: Tiles

[Night-Pryanik]

Could you please provide a screenshot?

[Quintovir]

• OS: Manjaro Linux 64-bit
• Game Version 0.C-36458-g59a72789a6-dirty
• Graphics version Tiles

clothing from zombies and what should be my ++ reinforced_gear_name

freshly pulped zombie corpses

[Barhandar]

You can upload images directly to Github you know.

Can confirm on 0.C-36502-g59a72789a6-dirty, item names do not show damage, but their descriptions do have the "protection is reduced by damage, you could repair this item" thing.

[CoroNaut]

Are you sure you have the "Options->Interface->Show item health bars" set to true?

[Quintovir]

Are you sure you have the "Options->Interface->Show item health bars" set to true?

Yes.
I even set it for the first time to false to see if anything changed. No change.

[Barhandar]

Are you sure you have the "Options->Interface->Show item health bars" set to true?

There is no difference in item display regardless of what said option is set to, i.e. items show neither healthbars nor damage prefixes.

The code that determines prefixes (for both damage and burning - can someone please check if prefixes for burnt items do not show as well?) is in material.cpp, but it had no functional changes for several months, so this issue would've gotten noticed much earlier.

EDIT: After a bit of half-testing, I've found that the issue was introduced in the output build 8422. I have no idea what commit(s) this corresponds to, but it does narrow it down by a lot.

[DavidEdwards]

I can confirm this issue. I compiled the latest version tonight due to Ubuntu ncurses library issues.

I was confused to see my items have no health on them. Item health bars are true in the config.

I walked into a horde of zombies, items registered no damage. I went through them with the welder to repair them. Some needed repairs.

[Barhandar]

Okay, so after manually checking the most obvious visual change, 8421 does not have cleanup of sidebar UI yet, while 8422 does, so somewhere around that commit is the breakage.

[Solusphere]

Just noting that in case this is still needing confirmation, there are quite a few people asking why item health isn't showing on the discord. I'm just showing them this issue for now.

[nsklaus]

i think i might be responsible for that.

item.h:312 
std::string tname( unsigned int quantity = 1, bool with_prefix = false ) const;

yes that's the line, i've just tested with bool with_prefix = true and it works again. sorry about that

[nsklaus]

just a quick note:
am i supposed to do something about it now that the pull request have been merged ?
what is the usual course of action in this kind of case, beside helping here by pointing the cause of the problem in the sources ?

[DavidEdwards]

I don't know how it goes in this repository, but usually the person who made the PR originally has "ownership" of the changes. So they make additional PRs to fix bugs relating to it.

Usually this makes sense, because that person understands what changes they made and why they made them.

[nsklaus]

done: here
@DavidEdwards : thanks for letting me know.