Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RV kitchen and seat storage appears broken #2772

Closed
minakitty opened this issue Aug 31, 2013 · 14 comments

Comments

Projects
None yet
4 participants
@minakitty
Copy link
Contributor

commented Aug 31, 2013

Whenever i try to store something in the kitchen unit or in a seat, it immediately drops to the floor. Not sure if that was a program change or a bug?

@kevingranade

This comment has been minimized.

Copy link
Member

commented Aug 31, 2013

Do you mean it lands on an adjacent floor tile instead, or it falls through
to the ground under the vehicle?

@ianestrachan

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2013

Probably the result of #2718. Only vehicle parts with the "CARGO" flag and a "size" variable can hold items now.

This functionality should be restored, taking advantage of the fact that the size limit actually works now, by having seats be able to store stuff (but not as much as a box or trunk).

@minakitty

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2013

@kevingranade It drops through with a message that there wasn't enough room, so stuff fell on the floor (same message you get when you overload a trunk

@ianestrachan Just so I know, is there a PR out that has restored the functionality, or do I just play as I have been for awhile longer?

@minakitty

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2013

@ianestrachan Scratch my earlier question. I'm still fairly new to git mechanics, and I just translated the PR you referenced earlier. Since it got merged into the master 3 days ago, that means I'm running that version (I just cloned the master last night). So I will just wait for a PR to restore functionality =^_^=

@ianestrachan

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2013

@heatheriac That's correct, though I realize my wording was a little ambiguous. When I said "should be restored" I meant "someone should fix that" not "it should have been fixed already".

@minakitty

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2013

@ianestrachan That's fine. I'll learn =^_^=

@NaturesWitness

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2013

I'll try and do a fix for this later, shouldn't be too hard. Not quite sure what the exact cargo capacity should be though, so I'll just wing it and if it's wrong we can always change it.

@minakitty

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2013

@NaturesWitness awesomeness! My RV is almost out of storage without some creative modifications

@NaturesWitness

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2013

Ok, wow. Just looked at the vehicle parts json, and if I'm reading it right, the RV kitchen, seat, bed, welding rig, and floor trunk are ALL broken! I'll try to get this fixed later tonight, since apparently right now vehicles have almost no storage parts at all! (Looks like only box and trunk work, so that means 2/3 of all storage items are out!)

@minakitty

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2013

@NaturesWitness uh huh ... now you see why i've been so grumpy. i have four storage tiles where i ought to have 9 in the RV. Wait ... welding rig? What is this welding rig you speak of?

@NaturesWitness

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2013

It's a vehicle part I added in a PR a week or so ago. It's similar to an RV kitchen, but instead of a hotplate, it gives you a welder and soldering iron that run off the vehicle's storage battery. It gives you a renewable means (vehicle solar panels) to fuel your welder to make repairs to your vehicle, so you don't have to waste so much time scavenging every last battery in a hundred miles to run the blasted welder. Rarely found in garages, can be crafted with 4 electronics skill.

PS - It's nice to hear people are using my RV, I found the abandoned PR for it on Github and decided to finish it. It was harder than I thought it would be, I had to make an entirely new kind of wheel (underbody wide wheel) to get it working without it having giant holes in the ceiling :)

NaturesWitness added a commit to NaturesWitness/Cataclysm-DDA that referenced this issue Sep 1, 2013

make vehicle storage function again (fixes CleverRaven#2772)
Apparently in the jsonizing of the vehicle parts we broke 60% of the
storage tiles  Whoops.  Anyway this should fix the seat, bed, RV
kitchen, floor trunk, and welding rig.
@minakitty

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2013

The welder? Running off battery power? This has only been my number one feature request since like, day three of playing the game. THANK YOU!!!!!!

@minakitty

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2013

Appears fixed, thank you!

@minakitty minakitty closed this Sep 1, 2013

@NaturesWitness

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2013

No problem glad I could help! Next, I want to make a wood-burning steam turbine engine so we can run our deathmobiles off 100% natural smashed wooden benches :) This is probably beyond my coding skill though, so we may have to wait until some smart person codes in a gas-powered electric generator for me to copy the tough bits off of :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.