New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles with combustion engines not producing smoke #28159

Closed
davidpwbrown opened this Issue Feb 10, 2019 · 4 comments

Comments

5 participants
@davidpwbrown
Copy link
Contributor

davidpwbrown commented Feb 10, 2019

Describe the bug
Vehicles don't produce smoke currently.

To Reproduce

  1. debug in a vehicle with a combustion engine, drive it, no smoke is produced.

Expected behavior
Combustion engines should produce smoke like they used to.

Versions and configuration(please complete the following information):

  • OS: Lubuntu 18.10
  • Game Version fresh master
  • Graphics version tiles
  • Mods loaded dda

Additional context
May be tangentially related to #28079
in that conditional checking for engine_type uses ammo_current instead of fuel_current, and dosnt return expected results.
spew_smoke checks fuel_type too, so it may be all related to that, not sure when smoke stopped being produced.
Was asked to @mlangsdorf with this.

@DSeyka

This comment has been minimized.

Copy link

DSeyka commented Feb 10, 2019

Might be related, when driving a vehicle with a leaking tank it no longer seems to leave puddles of gasoline behind it like it used to.

@davidpwbrown

This comment has been minimized.

Copy link
Contributor Author

davidpwbrown commented Feb 10, 2019

Yeah definitely sounds like the same root cause.

@Shodan14

This comment has been minimized.

Copy link

Shodan14 commented Feb 11, 2019

I kind of remember trying to use a in-door generator with an exhaust outdoors, but all the smoke still came out next to the engine. Not sure if that's related.

@kevingranade kevingranade added this to Need Confirmation in 0.D Release via automation Feb 13, 2019

@kevingranade kevingranade added this to the 0.D milestone Feb 13, 2019

@kevingranade kevingranade moved this from Need Confirmation to Confirmed in 0.D Release Feb 16, 2019

@mlangsdorf mlangsdorf moved this from Confirmed to Fix Proposed in 0.D Release Feb 16, 2019

@kevingranade

This comment has been minimized.

Copy link
Member

kevingranade commented Feb 17, 2019

Fixed by #28222

0.D Release automation moved this from Fix Proposed to Closed Issues Feb 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment