Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind turbines do not charge car battery on hippy van #28219

Closed
Duhuh54321 opened this issue Feb 16, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@Duhuh54321
Copy link

commented Feb 16, 2019

Describe the bug
Wind turbine does not charge battery when I install it on a hippy van.

To Reproduce
Steps to reproduce the behavior:

  1. Start at evacuation shelter.
  2. Spawn hippy van, 2 car batteries, 2 wind turbines, 1 toolbox
  3. Set mechanic to 10 and install the parts to the van.
  4. Remove the existing battery of the van, which has 100% charges
  5. Wait. And notice that the two 0% battery never get charged.

Test at place not near forest

  1. Remove the two 0% batteries. Install 100% battery.
  2. Drive van to place not near forest.
  3. Remove the ~100% battery. install the 0% batteries.
  4. Wait. And notice that the two 0% battery never get charged.

Test removing roof

  1. Remove the roof tiles of the car that are below the wind turbines.
  2. Wait. And notice that the two 0% battery never get charged.

Expected behavior
Expect car batteries get charged. I think I can install the wind turbine above the roof. Other parts of the car should not make the wind turbines stop working.

Screenshots

test_wind

Versions and configuration(please complete the following information):

  • OS: Linux
  • Game Version: 0.C-37450-ga123eea3e6
  • Graphics version: Tiles
  • Mods loaded: No extras. I just use the default ones.

Additional context
I have just git pull and recompile the game.
I didn't delete any old files.
save:
Test Wind2.tar.gz

@davidpwbrown

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2019

Removing the roofs and boards around the turbines allowed them to start charging.
This is down to the if( g->is_sheltered( global_part_pos3( part ) ) ) { continue; }

Confirmed, yet will need to look into it some more, to disable surrounding vehicle parts as wind blockers. ( the assumption is that its taller than other parts )

@kevingranade

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

Fixed by #28229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.