Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few issues with new panel layout #28813

Closed
OzoneH3 opened this issue Mar 19, 2019 · 13 comments

Comments

Projects
None yet
8 participants
@OzoneH3
Copy link
Member

commented Mar 19, 2019

  • Defaults to "Label" style should be classic

  • Player centering completely messed up (Not taking panel size into account)
    Auswahl_025
    Auswahl_027

  • No pixel minimap displayed even if active (Crashes after toggling it onand off with N #28812)
    Auswahl_023

  • List items: Monsters tab messed up/missing lines. (Items got fixed it seems)
    Auswahl_026

  • Panel Admin lable artefacts in curses mode after moving some around.
    Auswahl_029

  • Panel manager hardly usable on minimum resolution
    Auswahl_022

@Tharn

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

More of a feature, but the message log in 'compact' and 'labels' mode is also tiny. Would be nice to give it a bit more room or be able to set number of lines.

@NEONZARIN

This comment has been minimized.

Copy link

commented Mar 19, 2019

image
Where are these settings? I want to enable classic panel.

@OzoneH3

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

Where are these settings? I want to enable classic panel.

It's accessible with the } key.
Should probably get its own ESC menu entry and remove the keybinding.
They are scarce enough and nobody is changing the sidebar style every 2 minutes.

@NEONZARIN

This comment has been minimized.

Copy link

commented Mar 19, 2019

They are scarce enough and nobody is changing the sidebar style every 2 minutes.

image
Thanks for the info, it looks so much better. Is it possible to somehow lower the panel down? As in this screenshot.

@KorGgenT

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

thank you for your concerns.
no, it won't default to classic, that's a decision from kevin. it saves what you choose when you close the game anyway, so it shouldn't be an issue beyond when you first load.

not really sure what to do about minimum resolution panel manager, unfortunately. do you have any suggestions for that?
my priority is as follows:

  • fix crash bug (will fix pixel minimap being shown while i fix the crash)
  • fix centering oddity
  • fix monster tab
@n3tr4k

This comment has been minimized.

Copy link

commented Mar 19, 2019

I don't see any minimap even after number of reloads, and in SIDEBAR OPTIONS it's ON. After I tried to activate minimap I've got Segfault (I'm gonna to open a separate issue on that)

@Tharn

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

There already is one. OP linked it.

@KorGgenT

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

I don't see any minimap even after number of reloads, and in SIDEBAR OPTIONS it's ON. After I tried to activate minimap I've got Segfault (I'm gonna to open a separate issue on that)

no, don't open another issue. it's been resolved in the past couple minutes. set your pixel minimap height to 22, that should be square for you.

@n3tr4k

This comment has been minimized.

Copy link

commented Mar 19, 2019

I don't see any minimap even after number of reloads, and in SIDEBAR OPTIONS it's ON. After I tried to activate minimap I've got Segfault (I'm gonna to open a separate issue on that)

no, don't open another issue. it's been resolved in the past couple minutes. set your pixel minimap height to 22, that should be square for you.

eh, too late

@Redbox12236

This comment has been minimized.

Copy link

commented Mar 20, 2019

Just a suggestion, maybe there should be an option to choose where the "pick-up items" sidebar should be

@KorGgenT

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

once i figure out the ghosting issue, i'll consider that.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

If you have other issues with the sidebar, open a new issue.

Always open a new issue.

@KorGgenT KorGgenT referenced this issue Mar 21, 2019

Merged

Ui fixes #28884

@CleverRaven CleverRaven deleted a comment from junkyjb Mar 21, 2019

@CleverRaven CleverRaven deleted a comment from tinukedaya Mar 21, 2019

@CleverRaven CleverRaven deleted a comment from Fris0uman Mar 21, 2019

@CleverRaven CleverRaven deleted a comment from Gmiz Mar 21, 2019

@CleverRaven CleverRaven deleted a comment from tinukedaya Mar 21, 2019

@CleverRaven CleverRaven deleted a comment from Fris0uman Mar 21, 2019

@kevingranade kevingranade changed the title Everything wrong with new panel layout A few issues with new panel layout Mar 21, 2019

@KurzedMetal

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

The km/h display has a bug too on Classic mode, sometimes it overlaps the numbers:

With -12 current speed and high target speed (green part) it works kinda fine (no space before ">")
20190321_182428_cataclysm-tiles

But if I get to negative target speed a bit I get something like:

20190321_181339_cataclysm-tiles

Classic/Label don't show overlapping in my tests but sometimes it doesn't show an space before ">" either. Like:

20190321_181615_cataclysm-tiles

Also, I'm just noticing that Classic have the blue part (current speed) on the left while Compact/Label has it on the right, it would be nice having consistency here between all 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.