Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great helmet equip bug #29171

Open
Foxtrot-Uniform42 opened this issue Mar 31, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@Foxtrot-Uniform42
Copy link

commented Mar 31, 2019

Describe the bug
It is impossible to equip great helmet

To Reproduce
Steps to reproduce the behavior:

  1. Make a wish for great helmet
  2. Try to equip
  3. It says that "You can't wear that much on your head", even if you naked.

Expected behavior
A helmet should be possible to be worn

Versions and configuration(please complete the following information):

  • OS: win10
  • Game Version: 0-D-1214-g5225ecb
  • Graphics version: Tiles
  • Mods loaded: DDA
@Photoloss

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

For context: this is a consequence of adding the HELMET_COMPAT flag in PR #28554, potentially a bug/oversight from PR #23089 or an incorrect application thereof. The game strictly enforces an encumbrance limit on non-main helmet items and the great helm either misses the exception flag or there is none.

Historically speaking it should be possible to wear a fitted great helm alongside fitted chainmail or a Bascinet-style helmet (a slim visorless version) as well as a helmet liner standing in for a skullcap. This was the attire of the crusaders although solutions which preserve the mouth encumbrance should be preferred as they did in fact often elect to raise/remove the great helm for easier breathing during melee combat (same for later visored helmets). Unfitted historical helmets should still be wearable if the implication is that merely their fabric padding needs adjustment, and completely unwearable even on their own if the metal shell is too small.

@TheMurderUnicorn

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

So, do we remove the helmet_compat flag or do we adjust the encumbrance on the great helm? Neither is ideal, but there's no point in it being in the game if it literally can never be worn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.