Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action highlights are rendered offset after sidebar changes #29256

Closed
ralreegorganon opened this issue Apr 3, 2019 · 1 comment

Comments

Assignees
No one assigned
Labels
<Bug> Info / User Interface
Projects
None yet
Milestone
No milestone
2 participants
@ralreegorganon @reed501
@ralreegorganon
Copy link
Contributor

commented Apr 3, 2019

Describe the bug
Certain actions (e.g. examine, open) call choose_adjacent_highlight which highlights the locations that can be interacted with for that action when in Curses mode. Following the sidebar changes, this highlight is offset.

To Reproduce
Steps to reproduce the behavior:

  1. Use Curses mode
  2. Stand next to a door
  3. Press the key to open a door (default o)
  4. Notice that the highlight is offset

Expected behavior
The highlight should be drawn in the same location as the thing being highlighted.

Screenshots
before
image

after, notice the brown + offset to the right
image

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version: 0.D-1371-g46cfae9ca7
  • Graphics version: Tiles (with tiles disabled in the options menu)
  • Mods loaded: default

@ralreegorganon ralreegorganon added <Bug> Info / User Interface labels Apr 3, 2019

@ralreegorganon ralreegorganon referenced this issue Apr 3, 2019

Merged

Adjust pit digging mechanics #29259

@reed501

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Apr 4, 2019

I think this might be the same issue as #29186

@Zireael07 Zireael07 referenced this issue Apr 4, 2019

Closed

View jumps when performing actions which hide the sidebar #29275

reed501 added a commit to reed501/Cataclysm-DDA that referenced this issue Apr 7, 2019

@reed501
Realigns action highlights in ASCII 
After the sidebar update, ASCII versions had lots of highlights off
center. This adds the sidebar offset onto the highlight. They were
shifted off to the right due to the new sidebar changes. Things
affected: open, close, examine, maybe more.

closes CleverRaven#29256
1724595

@reed501 reed501 referenced this issue Apr 7, 2019

Merged

Ascii offset fixes #29359

@kevingranade kevingranade closed this in #29359 Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.