Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half of existing gear became "too big" after merging PR 28123 #30410

Open
dom4op opened this issue May 11, 2019 · 7 comments

Comments

Projects
None yet
7 participants
@dom4op
Copy link

commented May 11, 2019

Describe the bug
Stuff like holsters, sheathes, canteens now have "too big" added to their names. Even those which I make from scratch and supposedly for myself are "too big". There is no encumbrance penalty, it's just mildly irritating to see stuff like "pair of binoculars (too big)".

Link to PR in question: #28123

To Reproduce
Craft a holster/sheath/canteen. It's too big.

Expected behavior
Would be great if there wasn't "too big" mark on gear that actually fits.

Screenshots
https://i.imgur.com/J9bZni2.jpg

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version: 8940
  • Graphics version: Tiles
  • Mods loaded: none
@XhameX

This comment has been minimized.

Copy link

commented May 11, 2019

I have the same problem as of #28123 PR and it's really annoying.
Most of the "Too big" tags seems to be connected with the Tag
"This clothing is large enough to accommodate abnormally large mutated anatomy."
"This piece of clothing is oversized and does not fit you."

To Reproduce
Do what @dom4op wrote.
Add a shoulder strap mod to a gun.
Craft a Cloak.
Craft a Pouch.
Craft a Bandolier /Rifle/Shotgun/Pistol.
Craft a Patchwork quilt.
Craft a Survivor rucksack
Find a pair of binoculars.
Improving the fit on items still have the "too big" tag.
For example the stealth cloak.

And much more.

Expected behavior
What my survivor craft should not have this tag since he/she is not crafting the item for another NPC.
When it says my survivor improved the fit i expect it to fit obviously.

Screenshots
cataclysm-tiles_Oqwdk86Ih7

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version: 0.D-2810 tiles, Build 8941
  • Mods: Too many but i edit them for myself and making sure they throw no errors on start.

This is my first time writing here and if should make a new issue post about this and delete this one let me know.

@chaisawlajatang

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

I have this problem too, it happens with a lot of clothes and gear.

@Leosky

This comment has been minimized.

Copy link

commented May 12, 2019

It seem to happen to every items considered big enough to accommodate to large mutations.

@Leosky

This comment has been minimized.

Copy link

commented May 12, 2019

I checked doc and json and code i think it come from recent code addition in 70a8c03

Regarding code it may be change on how oversize works and json may not have been adapted.

@MetroidHunter

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

My apologies. I will look into this very soon. This comes from a change in the aforementioned PR around how we handle OVERSIZED gear and what FITS means. I will be sure to add a unit test of some kind to check for these cases

@Leosky

This comment has been minimized.

Copy link

commented May 13, 2019

My apologies. I will look into this very soon. This comes from a change in the aforementioned PR around how we handle OVERSIZED gear and what FITS means. I will be sure to add a unit test of some kind to check for these cases

Well, i though a bout it an i was wondering if it was intended. Cause when you see a blanket being 'too big' and the overzised definition it was quite logical. May be it could be kept like that and add a 'larger' tag for the old oversized ?

@esotericist

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Looking over the discussion history of the pull request in question ( #28123 ) it seems like the core problem here is a disconnect over the intent of the "oversized" flag.

The game had the assumption that "oversized" meant "can be worn by normal sized players or large players" approximately equally well, and it appears that @MetroidHunter was attempting to change that definition.

It was pretty clear from kevin's comments here that he did not receive the understanding that the definition was being changed intentionally (and honestly I couldn't pull that understanding out of the PR description myself, I only realized it after the fact while looking through the discussion).

So when kevin asked for the additional encumbrance penalty to be removed, metroidhunter complied, but did not walk back any of the other UI changes that went along with metroidhunter's revised definition of the term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.