Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known recipes and read books not saved #30744

Closed
Koalabog opened this issue May 22, 2019 · 10 comments · Fixed by #30778
Closed

Known recipes and read books not saved #30744

Koalabog opened this issue May 22, 2019 · 10 comments · Fixed by #30778
Assignees
Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics

Comments

@Koalabog
Copy link

Koalabog commented May 22, 2019

Describe the bug

Read books and recipes don't appear to be saved or loaded properly
Happened first when updating to build 9021 through launcher and it deleted the entire game instead. I used a settings file from an old backup but that probably shouldn't cause this issue?

Steps To Reproduce

Steps to reproduce the behavior:

  1. Read a book and craft something from it until you memorize the recipe
  2. Save and close game
  3. Load
  4. I would now be presented with a red book title and not having the recipe memorized

Expected behavior

A less forgetful character

Screenshots

All the books i have from various places and definitely read
image
When searching "Storage" in crafting menu
image

Versions and configuration

  • OS: Windows [64-bit]
  • Game Version: 0.D-3321-gdec03b2
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Weapon fixes [variousweaponfixes],
    Vehicle Additions Pack [blazemod],
    Tanks and Other Vehicles [Tanks],
    Boats [boats],
    Craft Ammo Mags & Belt Links [SD_Magcrafting]
    ]
@TechyBen
Copy link
Contributor

TechyBen commented May 22, 2019

Yep. Also getting this when I test for it (librarian start starts with books, save/exit and reload and they are all red).
[edit] Working ok/as intended in 9019 when I revert. Latest build has the bug.

@EternalLaughter
Copy link

Same issue here with build 9025, reverted back to 9020 where it's working as intended.
Hope you didn't save in the new build, or backed up your saves, otherwise you got alot of reading to do.

@ifreund
Copy link
Contributor

ifreund commented May 22, 2019

Looks like this is most likely caused by #30708

@ifreund ifreund added <Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics labels May 22, 2019
@Dekker3D
Copy link
Contributor

Possibly related: I forgot all my missions, including any that I'd finished before.

@Koalabog
Copy link
Author

Koalabog commented May 22, 2019

From what i can tell selected martial art is also not saved as it resets to "No Style" every time i load, though at least you dont forgot the martial arts entirely

@ifreund
Copy link
Contributor

ifreund commented May 23, 2019

Found the issue, will push a fix soon

@IvanShestakov
Copy link
Contributor

IvanShestakov commented May 23, 2019

@ifreund I'm still getting the issue with latest version (which includes commit ed96404). Linux, built from source using make clean && make -j4 CCACHE=1 TILES=1 SOUND=1 LUA=0 LOCALIZE=0 RELEASE=1 ASTYLE=0 command.
The books aren't red anymore - but the auto-learned recipes don't show: specifically for character which started with 4 electronics and could create EMP grenades from hour 0.

@ifreund
Copy link
Contributor

ifreund commented May 23, 2019

Can't confirm this. Just made a new character with electronics 5 and the auto learn recipes persisted through a save and load. It's possible that loading and saving the game while this bug was in effect could have deleted some data, but there's nothing that I can do about that.

It is recommend to back up your saves when playing the experimental version.

@IvanShestakov
Copy link
Contributor

Thanks for checking this out. Sad that I can't continue with this character then :( as it doesn't have the recipe shown - even though I've got the book with EMP grenade recipe... I made sure it isn't hidden or something. Just isn't there.

@Randonx
Copy link

Randonx commented May 24, 2019

I noticed that too Ivan. My character can't make several electronics that he could before, even with the same books I had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants