JSON Parsing and I18N, syntax errors on floating point numbers

[lastmikoi]

The current JSON parsing is locale-dependent.

That is to say, the parser will interpret numbers as to be internationalized.

Steps to reproduce :

• Run cataclysm with LC_NUMERIC environment variable set to any language using commas instead of dots for floating point number (such as fr_FR)
• Enjoy syntax errors on every single floating point value defined in every json files

[yobbobanana]

Gosh that is unfortunate. I guess that makes the 0.8 version unusable for languages that don't use a compatible decimal format?

I think this should be fixed when i move things over to the new json parser, as it shouldn't have this problem. It does the parsing manually, thus completely ignoring the locale. I think about half of the files have been moved over already, so should be about a week for the rest.

The only way to fix 0.8 would be to explicitly override the LC_NUMERIC setting, i guess.

[i2amroy]

Or people can change their localization setting on their computer when they want to play. Since there already is a relatively easy fix for it, it might be better just to focus on fixing it in the experimental.

[uzername]

This issue affects me too. I've closed my bug report.

[goron111]

we should change the locale on the json stream.

imbue should do what we need
http://www.cplusplus.com/reference/ios/ios/imbue/

[yobbobanana]

#3279 fixes this for 0.8. It will cease to be an issue when everything is converted over to the new json loader.

[goron111]

Can be closed