Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon stuck-ins produce no message. #3380

Closed
Rivet-the-Zombie opened this issue Oct 1, 2013 · 4 comments

Comments

Projects
None yet
5 participants
@Rivet-the-Zombie
Copy link
Member

commented Oct 1, 2013

@KA101

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2013

Probably should be checked with conventional weapons? Not sure if something broke in the MA rework (weapons block a lot more now, so ???) or if it's a problem with using a weapon-mod weapon. Am pretty confident that conventional stuff gave warnings when they got stuck.

(Whether one would notice them is another story.)

@spurberger

This comment has been minimized.

Copy link

commented Oct 3, 2013

I can confirm this as well. My machete always was getting stuck in enemies who could even proceed to run around with it in their bodies. No warnings shown. After killing the swyrm with it and machete turning into dented machete it stopped getting stuck, don't even know why.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Oct 7, 2013

A test shows that the game is properly getting to the line where it should be displaying the message (1160 in melee.cpp) and when I put in "g->add_msg("test")" it printed that just fine, so the problem seems to be that it doesn't want to print the g->add_msg_if_player for some odd reason.

@ianestrachan

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2013

Just poked into this one - it's because "p" is null, for whatever reason. I'll keep looking at it, unless someone has an idea of why the player pointer is null all of a sudden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.