Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic "I updated to build 9612 and now X is broken" Issue #33941

Closed
Malkeus opened this issue Sep 10, 2019 · 3 comments

Comments

@Malkeus
Copy link
Contributor

commented Sep 10, 2019

Ok, so Build 9612 has tightened up the standards for json error enforcement. This is going to cause a lot of issues with various mainline mods. Rather than issues being reported randomly as encountered and possibly duplicated, lets collect them all here for now. A specific issue for each error reported can then be made. Please read all the comments to make sure your issue hasn't already been reported. If you know of a fix, include that as well, please.

I'll start us off with the one making the rounds in discord right now about
CRIT Expansion Mod:

 DEBUG    : Error: data/mods//CRT_EXPANSION/crt_materials.json: line 14:22: Expected string
    "elec_resist": 20,
    "chip_resist": 9,
    "repaired_with": [
                     ^
                       "plastic_chunk", "chunk_rubber" ],
    "salvaged_into": "chunk_rubber",
    "dmg_adj": [ "ripped", "torn", "shredded", "tattered" ],
 
 FUNCTION : bool main_menu::new_character_tab()
 FILE     : src/main_menu.cpp
 LINE     : 843

It seems "repaired_with" only accepts a single material. Who knew.
Fix is to replace
"repaired_with": [ "plastic_chunk", "chunk_rubber" ],
with
"repaired_with": "chunk_rubber",

Lets get these all together and fixed ASAP. Try to only report issues with mainline mods here. Custom mods will need to be reported to their respective authors and/or fixed independently (please share your fixes on discourse).
That's all for now.

@Hirmuolio

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

#33940 fixes several issues like this (including this).

@Malkeus

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

Good, that is good. Hopefully all the errors will be fixed by the time I get off work later. Still, this will give the people in discord and discourse a place to point people who are continually asking the same question about the same error. Thanks for your efforts :)

@Malkeus

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@Malkeus Malkeus closed this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.