Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTool qualities aren't internationalizable #3824
Comments
This comment has been minimized.
This comment has been minimized.
|
It doesn't hurt anything to insert the same string into the database multiple times, does it? Can we just use the tool quality ID as the translatable string? Specifically I mean extract them from the qualities field of recipes and/or items. |
This comment has been minimized.
This comment has been minimized.
|
Yeah it could work to use the ID as the name as well, i just figure the english version might want a more descriptive name, too. Something like "Requires 2 tools with cutting quality of 1 or more.". The "CUT" term also shows up in item descriptions afaik. |
kevingranade
closed this
in
#3936
Oct 29, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
yobbobanana commentedOct 23, 2013
Right now the message for required item qualities in the crafting window says, for example,
Requires 1 tools with CUT of 1 or more.. It looks like the tool qualities (CUT) don't have names yet.I guess they should have their own json? Which would include name as well as ID.