Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical number is not used consequently throughout the strings #4649

Closed
Wuzzy2 opened this issue Nov 24, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@Wuzzy2
Copy link
Contributor

commented Nov 24, 2013

Support for grammatical number (singular/plural in English) is not consequently used but should. Since gettext has excellent grammatical number (gettext calls it “plural forms” for some reason) support, this should not be a problem. The offending strings which should have a grammatical number but haven’t are:

  • No. 635, 658, 659, 2363 and 2684 in Launchpad.
  • All item names. To show you that this is neccessary, I tell you that I even saw some strings with “%ss” which makes “plastic bottle” to “plastic bottles”, “cranberry” to “cranberrys”, oh, wait! And of course all occourences of “%ss” should probably be changed to “%s” after adding grammatical number support to the item names.

This list may be non-exhaustive. Please report any offending strings here.

Tested in: 0df165b

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2013

I found more offending strings in Launchpad for v0.9:

  • No. 10246
  • No. 10249
  • No. 10250
  • No. 10252
  • No. 10255
@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2013

More offending strings: 11303, 11306, 11308, 11309

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Dec 10, 2013

Another offending string (Launchpad ID for 0.9): 1679
This case is special, there are three words where the grammatical number applies. So this string would have to be splitted into multiple strings, I think.

Wuzzy2 pushed a commit to Wuzzy2/Cataclysm-DDA that referenced this issue Apr 9, 2014

Wuzzy
Add grammatical number support for many strings
So that grammatically awkward strings like “Upgrading bartering costs 1 points.” should be a thing of the past.

Note to developers: This has been done by calling
ngettext(singular_string_in_english, plural_string_in_english, number_to_determine_which_string_to_use)
instead of
_(some_string)
for the relevant strings. This commit touches a surprisingly large number of files.

This commit addresses all strings mentioned in GitHub issue CleverRaven#4649 (and some more) except item names.
Item names will (hopefully) be treated in a future commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.