Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faction names and descriptions impossible (?) to translate #4651

Closed
Wuzzy2 opened this issue Nov 24, 2013 · 5 comments

Comments

Projects
None yet
6 participants
@Wuzzy2
Copy link
Contributor

commented Nov 24, 2013

The way how faction names are generated is way too English-centric. It contains many word fragments which often are only meaningful in the English language.

I, as a translator, have no idea how to translate faction names. This is because the way how faction names are generated seem to assume a certain Grammar which is the English one. This system completely falls apart for other languages.

I am aware that factions are more or less on hold right now. But when the time has come that factions are being developed, I strongly suggest to start the name generator from scratch, but this time, with taking other languages into account.

Tested in: 0.9

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Nov 25, 2013

How about this, have each language provide a gramatical string or strings
used to generate the faction name, and also each one has its own list of
fragments. The only thing that would have to be the same would be the
number of fragments, though we could probably work around that if necessary
as well.
Will that work?

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Nov 25, 2013

It sounds like a sound idea. It would provide a lot more freedom.
At least I can’t any obvious flaws in your suggestion.
But I can’t say right now wheather it would actually work, sorry.
Because I am not sure wheather I understood your suggestion. Please explain further and give me an example or two.

@BrettDong

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2016

@illi-kun This issue can be closed.

Now faction names and descriptions have been moved into data/json/npcs/factions.json and they are all translated normally.

#. ~ Description for The Wasteland Scavengers
#: lang/json/faction_from_json.py
msgid ""
"Autonomous bands or individuals who make their living raiding the ruins of "
"the old-world for gear and provisions."
msgstr "各自为政的个人、团伙,在旧世界的废墟中谋生,搜寻着各种装备和给养。"

@illi-kun illi-kun closed this Nov 20, 2016

@AMurkin

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2017

faction::describe() not using translation for some strings

  • name.c_str()
  • facgoal_data[goal].name.c_str()
@BrettDong

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.