[Build 286] Disassembling = debug spam

[Rivet-the-Zombie]

From: http://smf.cataclysmdda.com/index.php?topic=4644.msg70013;boardseen#new

This message pops up after attempting to disassemble any item. It does not affect the results though.
It even pops up if you try disassembling an item that can't be disassembled.

DEBUG: Missing item (check item_groups.json): iv_mutant_troglobite

[Savidiy]

Savidiy@cb8a52e

[railmonkey]

Manually made the fix on my local build. It led to a crash. Details:

src/game.cpp[134]: data/json/items/comestibles.json: line 1:1: expected object or array, but found 'ï'

Being a code dummy, I have no idea what that second line means or how to fix it. The 'ï' showed up as ' ' in the console. I didn't make any changes to comestibles.json except for expanding "iv_mutagen_trog" to "iv_mutagen_troglobite".

[ianestrachan]

@railmonkey Since it says "line 1:1" you may have accidentally inserted a character at the start of the file. (I know I've done that enough times with a failed Ctrl-F...)

[railmonkey]

@ianestrachan Hm. I thought that might be it. If I did, though, I can't tell. Nothing else seems to have changed, like I said. Just tried it again with a fresh file (without using Ctrl-F) and got the same result.

[dwarfkoala]

Yeah, it does seem like it could be a copy error, but if it isn't i'm not sure what it could be.

I assume that the game works correctly without the fix? Your statement about the crash seems vague. Is it a crash on startup, a crash on disassemble, a crash on loading a character?

Can someone that's not railmonkey try testing this fix to see if they can reproduce railmonkey's error? I can't see how these 2 lines being changed would wreck the first line of the file, myself.

[KA101]

Just tried it in my (admittedly working) branch--hadn't tried fixing it there as expecting the PR to take care of it--and no crash on load. Any details?

[railmonkey]

@dwarfkoala Ah, sorry. Yes, it works correctly without the fix and it is a fatal crash on startup. I'm editing files with Notepad and I use Windows 7.

[swwu]

@railmonkey somewhat tangential but consider using notepad++ instead of notepad if you plan to push your changes. Aside from being an awful text editor, notepad doesn't by default handle Unix line endings (which most of the files have) very well and can mess up the file for other systems.

[railmonkey]

@swwu Heh. I don't plan to push any changes for a long while, but I'll make the switch and see if it helps (although I'm hoping I don't have to worry about this particular issue with the current build). Thanks.

That did it. Whatever Notepad was doing to mess things up, Notepad++ didn't. Fix went through as advertised.