Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Briefcase does not give fancy bonus. Stylish Trait. #5868

Closed
Soyweiser opened this issue Feb 1, 2014 · 14 comments

Comments

Projects
None yet
5 participants
@Soyweiser
Copy link
Contributor

commented Feb 1, 2014

The briefcase item (or any fancy item with an arm slot) does not give a fancy bonus as bp_arms and bp_mouth are missing from the if covered statements in line 571 of player.cpp (the if (has_trait("STYLISH")) part).

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2014

Oddly enough, I do get +1 from wearing a tie. Which has no body slots.

@VampyreLord

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2014

I don't know why briefcase is a fancy item to begin with.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2014

I think a briefcase and a tie is pretty stylish tbh. ;). There are more interesting stylish items. A clown suit for example. Making a list for the wiki right now.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2014

http://www.wiki.cataclysmdda.com/index.php?title=Stylish here. Odd things on it, firefighter stuff, clown stuff, maid oufit (debatable), the various cowboy hats, etc.

But it depends on what people want stylish to mean. It goes from western cowboy look to, plain silly, bling bling, and high class suits.

Personally I think the firefighter stuff should be removed. Clown can stay in as a nice joke. And perhaps not make all hats fancy. Not sure about the purse as well. Perhaps there should be made a new item a high end purse, a more rare one.

And I would love for the walking stick and the umbrella to be made stylish.

I have no idea if it all stacks. So if you can wear multiple bling items for a huge bonus.

http://www.kaisersbunker.com/feldgrau/helmets/fgh05.jpg not sure if fancy or just silly.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2014

Just tested it. Various items stack. Wearing 2 ties, and 2 tie clips gives a +4 bonus. (one for each).

Spawned more debug items and that gives this: http://prntscr.com/2oka8p http://prntscr.com/2okad3

@VampyreLord

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2014

Thinking about it, I think briefcases shouldn't be fancy, if not the opposite tbh. And yes, firefighter stuff shouldn't be also, why the hell they are? Umbrellas are used to prevent from getting wet and they shouldn't be fancy really.

What I consider something to be fancy is: a not so valuable item (for gameplay purposes) like the tie, gold watch, monocle, and top hat. The only reason you wear those is for the "looks".

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2014

A briefcase is shitty anyways. Don't mind it getting a bonus. And the bonusses are not capped and get insane with a random amount of bling. (spawned some tuxedo's, fancy watches and top hats, got it up to 43).

@VampyreLord

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2014

Yep, it should be capped.

@NaturesWitness

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2014

Ooh, if we add compatibility for mouth items to give stylish bonuses, we should really an a "diamond grill", a mouth item studded with diamonds. It don't get much more "Bling" than that.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2014

Did some more research. Stylish is 2 points as is optimist. Optimist gives a +5 bonus. All the time.

It isn't that hard to get +5 items with stylish, but a lot higher is harder (it took me some work, but I got my bonus up to +14 now, but I have been running around for a year).

So a cap will probably not do that much.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2014

Just a friendly reminder: Stylish exists to encourage folks to not go the "Max Storage Min Encumbrance" route. So every survivor doesn't end up in army pants/longcoat, PA, or survivor gear. (Or too HUGE to fit. ;-) )

Whether it succeeds at that is certainly open to discussion, and perhaps the approach might be debatable, but whether a particular item is FANCY or not depends more on its impracticality in a survival situation than actually fitting any particular fashion. (I for one have no plans to add fashion-specific flags.)

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2014

Well currently, I just used a lot of the non slot non encumbering items to get a lot of stylish bonusses.

+15 with tie clips, ties, watches, bling etc. So not working that great for it's purpose then.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2014

@NaturesWitness : #6182 you will love that.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Feb 18, 2014

If you manage to loot enough bangles and baubles and other non-encumbering jewelry to get a +15 to your morale, you deserve it. And you probably look like a pirate which is also cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.