Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tin can of curry with meat spoils #5873

Closed
Soyweiser opened this issue Feb 1, 2014 · 8 comments

Comments

Projects
None yet
5 participants
@Soyweiser
Copy link
Contributor

commented Feb 1, 2014

Like terrible person said when I complained about it on IRC:

Soyweiser: That still happens? I complained about it a while ago... realistically speaking, properly canned food never goes bad (not in a lifetime, anyways). Tastiness might deteriorate, but you should never have spoilage.

I agree. As long as you do not throw with the cans it should be allright

Edit:
http://smf.cataclysmdda.com/index.php?topic=5747.0 seems to be still around.


Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Feb 2, 2014

Yeah, fairly easy to fix, just a small JSON change.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2014

Don't know if it is that easy. It should spoil if you remove it from the tin cans. But not if you keep it in the cans. Not sure how that works.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Feb 15, 2014

Really canned foods should have two different "states", one in which they are opened and will spoil, and the other where they aren't. The problem now is that since there is only one state we are either forced to assume that all times a particular food appears it never spoils (regardless of container type) or that all cans are open and will spoil eventually.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2014

Basically, we need to make "can of X" work the same way as sealed plastic bags, jarred food, etc.

@illi-kun

This comment has been minimized.

Copy link
Member

commented Feb 16, 2014

It's probably linked with #3596.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Feb 17, 2014

Basically, we need to make "can of X" work the same way as sealed plastic bags, jarred food, etc.

Pretty much.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Feb 17, 2014

I wouldn't object if someone were to make a "uncan" iuse and all that jazz,
but the other thing I'd like to do is have a master iuse that handles
transforming one item into another, and have the data for the
transformation in the item definition.
This would allow json only creation of canned and activatable items, and
cut out a big chunk of redundant code from iuse.cpp
The tricky bit is items with multiple actions and menus :/

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2015

Think we nailed this one.

@KA101 KA101 closed this Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.