Inconsistent UPS behaviour.

[Soyweiser]

http://smf.cataclysmdda.com/index.php?topic=5408.msg89871#msg89871

as noted in that topic. For some weapons the UPS must be on, for others it doesn't need to be on. Bit inconsistent.

Turning on the UPS wastes batteries. The charge rifle could be recoded to just draw charge from the UPS when charging. (seems a bit needless micro to need to turn the UPS on and off every time before you shoot, esp as turning the UPS on and off takes no moves. Same for starting the charge, also takes no moves).

Coilgun, and the v29 and LACP laser pistol do not need you to turn on the UPS before usage. They just drain charges.

[dwarfkoala]

I really don't see the need for the UPS to be on in order to fire a weapon
if the weapon itself uses UPS charges once it's been fired.

On Wed, Feb 19, 2014 at 10:52 AM, Soyweiser notifications@github.comwrote:

http://smf.cataclysmdda.com/index.php?topic=5408.msg89871#msg89871

as noted in that topic. For some weapons the UPS must be on, for others it
doesn't need to be on. Bit inconsistent.

Reply to this email directly or view it on GitHubhttps://github.com//issues/6205
.

[Soyweiser]

[wito|work] The UPS probably shouldn't have an intrinsic power draw.
[wito|work] So that when it's on, it doesn't discharge unless something is drawing power.
[Soyweiser] Good point.
[Soyweiser] That fixes my problem with the ups.
[Iosyn] indeed
[Iosyn] thing is an active UPS drains more power than a flashlight even when you're not firing anything
[wito|work] yeah, when nothing is drawing, it should draw as much as a single green LED, i.e. negligible amounts of power.
[Soyweiser] Then you could make the UPS being on a req.
[Iosyn] also how would allowing advanced UPS to cover for the normal UPS as well
[Iosyn] seems advanced UPS can't power some things iirc

[kevingranade]

As far as I know only a few things like power armor and nv goggles rely on
turning the ups on and off, if we toggle them instead UPSs can become
passive battery containers.

If we do that we really need to wrap it in some method like "use item
power" that knows about power-providing items and hides the details.

[dwarfkoala]

I think UPS passive battery containers are more intuitive and easier to
make consistent than some kind of active power thingy that we have now.

[KA101]

Does #8283 (if/when merged) handle this adequately?

[kevingranade]

No, it still requires toggling the ups on and off to use the charge rifle properly. I think the full solution will be to eliminate ups_on vs ups_off entirely, they're just big lumps of batteries.