Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shockers always shock. #6302

Closed
Soyweiser opened this issue Feb 25, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@Soyweiser
Copy link
Contributor

commented Feb 25, 2014

Doesn't matter if you miss, use a stick, etc. A shocker always shocks you.

http://smf.cataclysmdda.com/index.php?topic=5490.0

@ClockworkZombie

This comment has been minimized.

Copy link

commented Feb 25, 2014

Looks like this is related to #6190 - if the weapon has "null" for a secondary type the conductivity check returns true. Also, if a miss makes it through the hit/damage routine there could definitely be some optimization done there. I can take a look at fixing this either way.

@OvenBaker

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2014

I'm reworking the hit/damage routine as part of the extensions for martial arts - the triggering of sp_defence on misses will likely be cured automagically as part of that.

Deliberately avoid the null conductivity issue as being out-of-scope for me though :/

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

Null-conductivity is closed, thanks to #6316 .

@KA101 KA101 added the Bug label Feb 26, 2014

@Soyweiser Soyweiser closed this Feb 27, 2014

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2014

Closed as the problem is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.