Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long item names overwrite weapon/equipment data #6358

Closed
Soyweiser opened this issue Feb 28, 2014 · 5 comments

Comments

Projects
None yet
4 participants
@Soyweiser
Copy link
Contributor

commented Feb 28, 2014

See this: http://smf.cataclysmdda.com/index.php?topic=5518.0

"The cough drops of inventory letter q have a very long name.
http://puu.sh/7dks1.png

And when scrolling back up, they overwrite part of the weapon. In this manner, the inventory letter of the weapon is sometimes also overwritten, leading to temporarily lost information.
http://puu.sh/7dksS.png

This is in release candidate 0.9-4834."

@i2amroy i2amroy added the Bug label Feb 28, 2014

@i2amroy

This comment has been minimized.

Copy link
Member

commented Feb 28, 2014

Right now this doesn't have an easy fix due to the string freeze. That said the easiest way would probably just be changing the name of cough syrup to something a little shorter.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Feb 28, 2014

Yeah we could just replace non-drowsy cough syrup with daytime cough syrup and it would fix this. Simple enough, once 0.A lands.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2014

Yeah. That is the simple solution. Does not prevent it cropping up later or on translations. We could fix it more elegantly i would say.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Feb 28, 2014

The difficulty in implementing a more "elegant" solution lies in the fact that the problem is in how our screen display is set up. Really the only way to handle this better would be to implement something that automatically shortened names appropriately when they were too long.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 1, 2014

ncurses and sdl text have a length limit for fields, it's just that a lot
of them have bad values. The only thing needed for this is determining how
much space we have and plugging it into the right method call. We still
have a lesser bug of "message truncated", but that's far more manageable.

BevapDin added a commit to BevapDin/Cataclysm-DDA that referenced this issue Jul 13, 2014

Merge remote-tracking branch 'upstream/master' into other-crafting-ap…
…proch

# By Chase (11) and others
# Via KA101 (9) and others
* upstream/master: (40 commits)
  Fix makefile version extraction logic to handle alpha characters.
  Final update to changelog, version fallbacks, motd, and credits before release.
  Only refresh after changing tilesets in the option menu if we're called from in the game. Fixes CleverRaven#6372.
  Category fix for two recipes.
  Adds tent_kit to dead-soldier itemgroup
  add debug function to remove all monsters
  Import translations from launchpad.
  Return a default name from name generator instead of crashing if no names are available.
  More item category fixes.
  fix for CleverRaven#6360
  Re-categorizes some shell casings as 'spare parts' instead of 'ammunition'.
  Update .pot
  Deletes unused variable
  Adds check for active first-aid
  Removes superfluous EATEN_HOT tag from peanut butter sammiches.
  Truncate item descriptions so they don't overflow into the inventory status display. Fixes CleverRaven#6358.
  Extract a magic number to a const.
  Fixes silly materials-based sock/shoe check.
  Small changes to HoderTileset to demonstrate tile category fallback behavior.
  Fallback categories for tile drawing.
  ...

Conflicts:
	Makefile
	data/json/items/melee.json
	src/inventory.cpp
	src/map.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.