Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshly made soup instantly rotten #6414

Closed
Greiger opened this issue Mar 3, 2014 · 19 comments

Comments

Projects
None yet
10 participants
@Greiger
Copy link
Contributor

commented Mar 3, 2014

It seems meat soup at least is being made rotten when created. I have confirmed that my storage contain no rotten ingredients but all meat soup made is instantly bad on creation.
This appears to happen with kompot and woods soup as well, but I have only thoroughly tested it with meat soup.

Save here: https://dl.dropboxusercontent.com/u/22514454/Pineridge.zip
The save has everything needed to make the soup nearby and unrotten, simply craft it in the menu.

Forgot to mention that this save asks for mod, it is here: https://dl.dropboxusercontent.com/u/22514454/Greimod.zip but it should function without it.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Mar 4, 2014

Were you storing the ingredients in the refrigerator? It's possible there might be some conflict being caused there.

@i2amroy i2amroy added the Bug label Mar 4, 2014

@BollandP

This comment has been minimized.

Copy link

commented Mar 4, 2014

I have had this problem for quite some time (at least since 0.9-3996). When I made certain foods such as cooked meat or broth during the summer, it came out rotten.
It may have to do with temperature effects on rotting. I did store some of the ingredients in a regular fridge, but IIRC they were not working back then (something about power).

@Greiger

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2014

I was indeed storing the meaty ingredients in a minifridge. If that may have something to do with it.

Also I forgot that I am using a custom mod, but unless I misunderstand the mod system there should be nothing influencing this recipe. Mod here: https://dl.dropboxusercontent.com/u/22514454/Greimod.zip

@Greiger

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2014

I just found more information, I found some flour and decided to make some bread. To go with my peanut butter (that does not rot). Making the peanut butter sammich, with 100% fresh bread and peanut butter still makes a rotten sandwich. None of the items were in the minifridge for any period of time.

Also after finding the debug message command lets me see the rot values for food I confirmed that stuff in a powered on minifridge appears to still be rotting normally they just don't get the (rotten) tag at the end. Fridge value on all items placed in a minifridge stay 0 and rot values are all high. This may be multiple issues.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Mar 5, 2014

My guess would be that the problem lies with the averaging of component rot values to find the rot of the new item made then, since it could be failing to account for fridge time at that point.

@Wishbringer

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2014

This happens even without using a fridge, it seems food that doesn't rot are still used in the calculations (they have an ever increasing rot value).

@dwarfkoala

This comment has been minimized.

Copy link

commented Mar 6, 2014

What if it just checks to see if the ingredients are rotten, then makes the
result rotten if any of the ingredients are?

Seems straightforward. If something's old but not "rotten," then it's
confusing if making something with that old item creates something "rotten".

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 6, 2014

Will try and repro with old unspoiling ingredients, if so that'll be an
easy fix.

@Wishbringer

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2014

Hmm, recently I'm getting rotten cooked meat from unrotten raw meat.

@kevingranade kevingranade added this to the 0.B milestone Jun 12, 2014

@Cosmitz

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2014

A bit of resurrecting a 'rotten' issue, but I think it's definitely tied to temperature. If it scales exponentially, the cut off for rotten may be a bit too low. In Spring i can keep food around for almost the whole season, but in Summer, it's almost instantaneous.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2014

Any reports after BevapDin's fix?

@Cosmitz

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2014

Tested a bit with various soups in 30 degree summer weather, and it turns out as expected. Rotten components make rotten soup, fresh components makes fresh soup. Also don't know if the instant food rotting in summer is related to the fix of this, but that's still a thing.

On the note of soups though... they seem to be awfully picky what can 'contain' them. Tins nope, pots and various usual soup-holding kitchen items nope, finally found that glass jars seem to work.

@BevapDin

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2014

On the note of soups though... they seem to be awfully picky what can 'contain' them.

Do you mean where to put the resulting item? The game applies the same logic to all liquids, any container that is watertight and can be sealed will do for any liquid. This works exactly the same for water as it does for soup.

Also: rotting in hot weather can be up to 6 times as fast as during "normal" temperatures.

@Cosmitz

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2014

So i can make soup in a 55 gallon drum? Cool. :D pours small pot of soup in an empty drum

Or meat soup in a hip flask come to think of it. But that's enough of my offtopic.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2014

OK, gonna link to #9283. If we don't hear anything by this time tomorrow, I'd call this closed.

@Robik81

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Woods Soup made from all nonperishable components but chunk of meat, which was 100% not rotten (I have them in fridge and I ate some from top and bottom stacks to check if they are really not rotten or it is just display bug) is still being made rotten.

Fix sadly does not work - in some cases at least.

@Robik81

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

@KA101

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

I suppose there may be a case where a save is unhelpful, but those are few and far between. Thanks, Robik81.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2014

OK, closing again. If there's a problem, let us know!

@KA101 KA101 closed this Oct 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.