Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container inventory management #9524

Closed
Robik81 opened this issue Oct 12, 2014 · 9 comments

Comments

Projects
None yet
5 participants
@Robik81
Copy link
Contributor

commented Oct 12, 2014

I am thinking about adding feature into AIM which would allow for easier moving of liquids between containers. Currently, if you want to move stuff from cans / bottles into jugs, it is a hassle. I would also like to add ability to store non-liquids into containers, as long as you put same items in there, no mixing of stuff.

Implementation:
In AIM, you would select container in one pane, it would switch that pane into the container pane, similar how vehicle pane is handled. You could then move stuff from other pane into it.

Thoughts? Is feature like this mergeable into mainline?

@KA101

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2014

This seems the same as our current [U]nload container and then pick new container approach, just reversed: pick new container, then pick container to unload. I suppose it might have debug value if one wants a non-standard container and the gas-pump trick won't work, though.

I'm not really sure this is worth the effort, though. :-/ Am I missing something?

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2014

You can use unload, but you have to move every container you want to unload into your inventory first and then unload each of them and select target container each time. Possible, but annoying.

With new feature, you would select target container only once, similar to grabbed vehicle, you would then see content of selected container in one pane and could move cans / bottles into it from other pane. Unloading would be automatic.

Also, there is no load and unload function for non-liquids.

If it is worth the effort... well, I am willing to implement it myself. I would like to avoid doing it and having it rejected though.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 12, 2014

Liquid handling is just fine, as long as you can implement it cleanly without duplicating a lot of code.
I'd rather not have stopgap methods for putting non-liquids in containers, it's a bad UI and would just interfere with a proper container-based inventory.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Oct 13, 2014

I like this idea!

It would very much simplify filling barrels full of soft drinks, 'cause I need a hundred liters of cola consolidated into a convenient package for reasons.

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2014

I will do the liquid handling then... or try and fail, didn't seen the AIM code yet.

@kevingranade I don't agree that it would be bad UI for non-liquid handling though. It is best I can think of, unless you want to go specialized window route. It is very similar to how file managers are handling files - items and directories - containers. IMO could be the first step in implementing container-based inventory.

@smmck

This comment has been minimized.

Copy link

commented Oct 15, 2014

It would be very helpful if I didn't have to pick-up a container to unload. I've caused injuries to my poor character from picking up full gas tanks that I wanted to empty for use in crafting.

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2014

Yes, it would be possible to unload too. You select target container, like jug and 'move' source container, like barrel into it, it would unload content up to target's capacity. You will not be able to unload on the ground this way, though.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2014

Since unloading to the ground wastes the liquid, pretty confident that folks won't mind that not being an option. Thanks for the discussion, and looking forward to this.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 17, 2014

@kevingranade I don't agree that it would be bad UI for non-liquid
handling though. It is best I can think of, unless you want to go
specialized window route. It is very similar to how file managers are
handling files - items and directories - containers. IMO could be the first
step in implementing container-based inventory.

Feel free to disagree, but explicitly managing items in containers will not
be merged. Liquid handling is already an exception so that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.