Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix "Smoke, electricity, etc. all invisible." with tiles #10131
Conversation
Rivet-the-Zombie
self-assigned this
Nov 22, 2014
Rivet-the-Zombie
added a commit
that referenced
this pull request
Nov 22, 2014
Rivet-the-Zombie
merged commit 80e9ef5
into
CleverRaven:master
Nov 22, 2014
BevapDin
deleted the
BevapDin:sdl-software-renderer
branch
Nov 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedNov 22, 2014
Fixes http://smf.cataclysmdda.com/index.php?topic=8402.0
I can reproduce this with software rendered on and tiles (non-fullscreen) and several tilesets.
However for some tilesets the acid is visible and smoke is not (Deon's).
For others (MShock24) neither smoke, nor acid nor sparks are visible.
The retro tilsets display all three fields (it seems this tileset does not use transparency as much as the other).
As the transparency is applied through the alpha channel, it seems to be caused by the
display_buffernot having an alpha channel (only RGB, 8 bit each -RGB888). This changes the display buffer to have an alpha channel. It works fine for me and fixes the issue.