Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upNew item descriptions - round 1 #10303
Conversation
added some commits
Nov 28, 2014
KA101
reviewed
Dec 2, 2014
data/json/items/ranged.json
Outdated
| @@ -1119,7 +1119,7 @@ | |||
| "color": "light_gray", | |||
| "name": "L2037 Backup", | |||
| "name_plural": "L2037 Backups", | |||
| "description": "The companion sidearm for the L523 modular system, this beast of an autorevolver has ups and downs. Unfortunately, it only chambers five rounds. Fortunately, they're the same as those used in the L523: .223. (Or in military hands, 5.56.)", | |||
| "description": "Developed by Leadworks as a companion sidearm to the L523, this massive autorevolver fires the powerful .223 round, but suffers high recoil as a result. It has a weighted barrel to make recoil more manageable and a 5-chamber cylinder.", | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I think the descriptions are fine as-is. Why the need to change them? |
This comment has been minimized.
This comment has been minimized.
|
I kinda like the existing descriptions |
This comment has been minimized.
This comment has been minimized.
|
@KA101 Mainly to make weapons easier to visualize. |
This comment has been minimized.
This comment has been minimized.
|
I'm not seeing an improvement either, just changes. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, this is a case of "PR exceeds the previously discussed spec and therefore gains more opposition than anticipated". Closing with leave to re-file the L2037 change as it is here, which I'll punch through. |
KA101
closed this
Dec 5, 2014
ghost
deleted the
item-descriptions
branch
Dec 6, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ghost commentedDec 2, 2014
New descriptions for the RM42, tanto, machete, kukri and L2037.