Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds check for threshold status and calls off the turret #10310
Conversation
kevingranade
added
the
(S2 - Confirmed)
label
Dec 3, 2014
KA101
added
in progress
and removed
in progress
labels
Dec 3, 2014
This comment has been minimized.
This comment has been minimized.
|
Note to file: sound range is a little less than 1:1 with tile distance. Had to amp up the WARNINGS a bit. |
kevingranade
reviewed
Dec 3, 2014
| // Target not human, presumably some weird animal, not worth the ammo | ||
| // TODO: Once NPCs can be targeted, add a check for whether the turret's damaged | ||
| // and if so, have it shoot whatever attacked it most recently | ||
| if (g->u.crossed_threshold() && !g->u.has_trait("THRESH_ALPHA")) { |
This comment has been minimized.
This comment has been minimized.
kevingranade
Dec 3, 2014
Member
I'd like the turret to at least start defending itself if attacked. It's ridiculously OP otherwise.
This comment has been minimized.
This comment has been minimized.
|
I was against crazy loudspeaker warnings when these turrets were first added, and I'm still against it. If people aren't going to notice one log message (laser dots), what makes you think they're going to notice a different one? |
This comment has been minimized.
This comment has been minimized.
|
Safe mode could toggle at the color level if that's simpler to code rather than "per monster". |
This comment has been minimized.
This comment has been minimized.
|
You mean the color of the monster? That's not easier at all. |
This comment has been minimized.
This comment has been minimized.
|
Tuning it to the difficulty range might be workable. I'll revert the loudspeaker warnings. |
This comment has been minimized.
This comment has been minimized.
Only because they specifically ask for warnings? That commit dropped three noisy warnings into the log, and was plenty loud enough to pull a horde if any happened to be in the area. In any event, it's reverted and I'll have damaged turrets bypass the thresh-check. |
This comment has been minimized.
This comment has been minimized.
|
There it goes. Anything else? |
kevingranade
reviewed
Dec 4, 2014
| if (z->hp == z->type->hp) { | ||
| if (g->u.crossed_threshold() && !g->u.has_trait("THRESH_ALPHA")) { | ||
| if (g->u_see(z->posx(), z->posy())) { | ||
| add_msg(m_info, _("The %s doesn't seem to consider you a target."), z->name().c_str()); |
This comment has been minimized.
This comment has been minimized.
kevingranade
Dec 4, 2014
Member
I'm a little concerned that people will get the impression that they are not and will never be a target based on the message, but I don't have a good alternative at the moment.
This comment has been minimized.
This comment has been minimized.
Rivet-the-Zombie
Dec 4, 2014
Member
How about: The %s doesn't seem to consider you a target at the moment. ?
KA101 commentedDec 3, 2014
for clearly non-human characters.
Incentive to not take Alpha, too, since those still pass for human. BMG turrets are designed for vehicles so can target HUGE folks. Tank turret is handled in the multi_robot scripting.