Even more folding parts!

[jokermatt999]

I've added alternators, batteries, floodlights, and a folding version of the shopping cart basket (and recipe). The basket is the only one that actually gets smaller when folded, however.

On the subject of balance, I was considering adding "foldable" to motors (edit: and perhaps even solar panels) to allow them as part of carry-able vehicles, but giving them no reduction in volume for folding_volume (like batteries and alternators). Does that seem alright/balanced? I don't really see any issues, but does anyone have a problem with it?

[jokermatt999]

Don't worry, I tested the json this time too.

[KA101]

kevingranade added the unknown label 21 minutes ago

Twilight Zone music plays

[jokermatt999]

Just curious, any reason for the "unknown" flag? Also, I'd do a separate pr for the engines/solar panels, if others think it's a good idea.

[NaturesWitness]

I like the idea of folding solar panels. I can see having sets of folding solar arrays for your mobile base. You set them up and hook them to your base with jumper cables when you make camp, and fold them and put them in the trunk when you want to move.

[KA101]

NaturesWitness has it right. I'm curious about the unknown flag too.

[jokermatt999]

Kevin, could I at least get some feedback about the "unknown" tag? It's kind of frustrating having this stuck in PR limbo when it's been validated and tested.

[NaturesWitness]

I'm actually curious about this too. For some bizarre reason I thought it was related to the Pokemon "Unown" from the gold and silver games.

BTW, why does everyone like Pikachu anyway? Everyone KNOWS Farfetch'd is the best Pokemon in the entire series.

[kevingranade]

It's a meaningless bug from waffle.io, ignore it.

[jokermatt999]

Heh, I was worried it was due to me falling to test previous prs. >>

And yes, Farfetchd is the best due to delicious leeks.
On Dec 11, 2014 11:36 AM, "Kevin Granade" notifications@github.com wrote:

It's a meaningless bug from waffle.io, ignore it.

—
Reply to this email directly or view it on GitHub
#10405 (comment)
.

[KA101]

Watch your spacing there.

[KA101]

After looking at this, I'm not quite sold on making all sizes of alternator fold up: a volume 8 alternator seems kinda large/bulky to be folded neatly. Wire baskets can be compressed, sure--I've seen and used 'em on a bicycle IRL--but the alternators, etc don't feel workable to me.

If I'm missing something important, let me know and I'll rethink.

[jokermatt999]

Should be all good to go. I'd like to leave the floodlights (as they were specifically requested) and the recharging station (for utility) as foldable, although neither really get any smaller.

[KA101]

I'm not sold on the recharge station but they can be small enough when not vehicle-mounted, so wev.

[KA101]

Looks like we forgot something in construction.cpp a while back: done_vehicle didn't have anything for folding frames, so using a folding frame to start vehicle construction created a standard, nonfolding one.

Was straightforward to fix though.