Vehicle cameras mod

[Coolthulhu]

The feature I've seen requested few times.

Cameras use mirror mechanics and are similar to them in many ways.

When sitting on a vehicle on a part flagged as "CAM_CONTROL", cameras work like mirrors seen by the player, except with offset being dependent on camera stats rather than distance to it.

I reuse VPFLAG_MIRROR, because it is used only in lightmap.cpp and only in this exact function that now also handles cameras. That way processing seen cache shouldn't be any slower when no mirrors or cameras are installed on current vehicle and only an incredibly tiny bit slower when there are many mirrors installed.

Cameras are installed on the roof, but (like turrets and overhead lights) they can't see through vehicle walls.

[Zireael07]

Cool!

[KA101]

OK, you've created debug tools. ;-) Not ready for prime time.

[Rivet-the-Zombie]

Yeah, with a less fanciful description and a small power drain while active this would be cool.

[Coolthulhu]

I think this should be ready for testing now.

I moved cameras out of the mod, I hope that's OK.

I added some energy cost to cameras, added an option to disable/enable them, renamed "omnidirectional camera" to "security camera" (because no other camera exists yet), gave things proper descriptions and renamed VPFLAG_MIRROR to VPFLAG_EXTENDS_VISION (because cameras use mirror mechanics).

[KA101]

Might let 'em spawn in electronic stores too. ;-)

[Coolthulhu]

Yeah, I'll add them later on. I have to make remote controllers spawn somewhere too, so that they can have low-level uses.
Camera systems could probably spawn in police stations.

I just prefer separating my code and json PRs, because it makes it easier for me to avoid conflicts.

[KA101]

I just prefer separating my code and json PRs, because it makes it easier for me to avoid conflicts.

Not sure how that works, but wev. >_>

[Coolthulhu]

It works like this: I'm bad at git. I learned how to rebase literally yesterday.
I also reuse same test saves for each PR and missing jsons add another layer of "what the fuck am I doing" to testing.

[KA101]

I've never had confidence in git rebase. I ask authors to fix substantive conflicts because you folks know what you had in mind. I don't necessarily have that knowledge.

Save-reuse, yeah, that could do it. I've had a few PRs that fell behind each other.