Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFacility items 003 chemicals (reprise) #10643
Conversation
Aenye
added some commits
Oct 7, 2014
This comment has been minimized.
This comment has been minimized.
|
Tomorrow's agenda: More items ! Drops for existing non-craftables. Comments: These are the most basic chems for now - can be readily expanded if necessary. There is a whole slew of questions I've jotted down in the last three months away and even more ideas... In short: nice to be back. ^^ |
BevapDin
reviewed
Dec 26, 2014
| @@ -0,0 +1,421 @@ | |||
| [ | |||
|
|
|||
| // Organisation note: Attaching the general character of the item to its id (e.g. chem_ammonium_nitrate) so as to keep the file structured by having the items sorted into continuous groups. | |||
This comment has been minimized.
This comment has been minimized.
BevapDin
Dec 26, 2014
Contributor
This is invalid json.
Have you even tried to launch a new game? Starting the cataclysm program is not enough, you need to load a new game to make the program load (and check) the json.
The json format does not support comments, but you can add valid json entries that are effectively ignored like this:
"//": "your text"
Some of the files there already contain comments of that form.
Edit: comments in this outermost array are not supported at all. The game assumes that all entries of that array are json object with a "type" member that indicates how the entry should be loaded.
You need to move the comment inside one of the item definitions (can be the first line).
BevapDin
reviewed
Dec 26, 2014
| } | ||
|
|
||
|
|
||
| //End file after this line. |
This comment has been minimized.
This comment has been minimized.
BevapDin
Dec 26, 2014
Contributor
Everyone can see this. But I don't see a "start file at this line" comment at the top, how am I supposed to know where the file starts? /sarcasm
Aside from being invalid json, it's pointless and redundant.
This comment has been minimized.
This comment has been minimized.
KA101
Dec 26, 2014
Contributor
When I was first transitioning from idea-gen to devving, I made mistakes similar to these. They happen, just try not to make 'em in future.
Aenye
added some commits
Dec 30, 2014
This comment has been minimized.
This comment has been minimized.
|
I've been testing most changes I make, however, my filesystem mess up decided to plague me again (too ashamed to publicly explain in more detail, but you can call me "blondie" (do you also have that stereotype ?) from now on). ...uploaded the proper versions now; sitting on adding the recipes to the 'cookbooks'. Actually, the explosives book could also use some of the simpler ones. |
Aenye
added some commits
Dec 30, 2014
This comment has been minimized.
This comment has been minimized.
|
Booked the non-trivials into the anarchist manual, the chem reference and the launchers / rockets book. PS: If You wanted to make thermite, it is basically mix the powdered ingredients + one more action - an inexperienced person typically completes this in about 2 minutes (hence the time), while with a bit of experience and a few "accessories" you can go down to something like 10-20 seconds for powder and under a minute for shaped thermite charges. The reaction times for RDX and HMTD were way off, though (still, shortened them a bit, so that the new explosives aren't as prohibitive in the amount of time you need to spend crafting the ingredients). ^^ The fun thing is that a lot of high explosives can be made in relatively quick reactions, whereas the safe stuff usually takes much longer - today we finished a reaction that was running for six days - the purification procedure will take another ten, though... PPS: Will be killing & setting up the system on my personal laptop again today, so I might not be able to respon immediately, but will surely pop in here once everything is done. |
This comment has been minimized.
This comment has been minimized.
|
We have that stereotype, but my sister is blond and MUCH smarter than me in |
This comment has been minimized.
This comment has been minimized.
|
Ugh, stereotypes. I've made mistakes too, so yeah, not one we believe in here. |
This comment has been minimized.
This comment has been minimized.
|
We've had some patriotic movies being aired lately and these are just packed with sterotypes, so some are resurfacing (unlikely that anyone believes in those, but you still hear pretty obnoxious lines every now and then). Apart from the "traditional" and blatantly false blonde = dumb, redhead = wild in bed (that one actually made me dye my hair - that's what you get for working in an environment with 90% of (horny) guys), there are some niche ones, like English = vampire (no bloody idea why, but our Dracula always has a British accent). That said, the PR seems good now. |
KA101
self-assigned this
Jan 1, 2015
This comment has been minimized.
This comment has been minimized.
|
PS: Happy New Year guys ! :* |
This comment has been minimized.
This comment has been minimized.
|
Hence why I'd like to get the fireworks merged in time. ;-) |
This comment has been minimized.
This comment has been minimized.
|
RDX charge either needs downtuned or the mininuke uptuned, as the keg-o-boom has a much nastier blast. But I'm inclined to leave it for another PR. |
This comment has been minimized.
This comment has been minimized.
|
Will boost the mininuke a bit, then - only a bit is needed, as the huge weight of the RDX charge (and the ingredient cost) are balancing factors in this. Mininuke boosted by 50%. Also "keg-o-boom" <3 |
This comment has been minimized.
This comment has been minimized.
|
I'm fixing this on my end, please don't file a commit: letters are kinda reserved for critters, rather than items. Most of these should be = for dry ingredients, ~ for liquids, * for the thrown charges, and I used ( for the keg. Just need to get that sorted, check up the books, and this'll be ready to go. |
This comment has been minimized.
This comment has been minimized.
|
Ok, not pushing any commits unless You say so. |
This comment has been minimized.
This comment has been minimized.
|
Added a couple to the chem textbook and cleaned up the JSON. And now, time to bring the noise. :-D |
KA101
merged commit e9745d3
into
CleverRaven:master
Jan 1, 2015
1 check failed
This comment has been minimized.
This comment has been minimized.
|
Hoorray ! Thanks for all Your help ! :D |
Aenye
deleted the
Aenye:facility_items_003_chems_reprise
branch
Jan 1, 2015
This comment has been minimized.
This comment has been minimized.
|
Thank you for all yours. :-) |
Aenye commentedDec 26, 2014
Using the discussion from #9215 I've put up a tiered system for chemicals and populated it with the first batch of chemicals and a nice bomb to keep things interesting.
In total, I am planning some 30 chemicals (15 out of the way already, 10 more shortly) and some 20 devices (among them: Thermite, RDX, HMTD, TCAP, Powder charge, Hexamine, Smoke curtain, Rocket Candy, Home-made rocket).
Please comment on what do You think of these ideas and tell me if there is something obvious, that I should add to the list.