Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wild stab at, stabbing weapon gaining cutting experience bug #11092

Merged
merged 1 commit into from Feb 3, 2015

Conversation

Projects
None yet
5 participants
@aierce
Copy link
Contributor

commented Feb 2, 2015

a wild stab at the bug where stab weapon gain cut experience

wild stab at, stabbing weapon gaining cutting experience bug
the roll_cut_damage does not exclude STAB flag, and this function (or class? my programming is rusty) is called before the roll_stab_damage, this could be why STAB weapons gain cut experience, but when cutting skill is disabled in game the game gain piercing experience normally.
@aierce

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2015

even if this doesn't fix the experience bug, this is still a valid bug fix, i think, maybe there are multiple bugs contributing to this problem

@aierce

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2015

OK Coolthulhu said on the forum:

"It works like this:

Every knife-type weapon deals "equally random" amount of cutting and piercing. As in, if it deals 1d10 cutting, it also deals 1d10 piercing.
Only the higher of the two is actually dealt.
Only the actually dealt damage contributes to training.

Most survivors get cutting quicker, because there are more (good) weapons that do this AND because cutting damage has a lower penalty from low skills.
Therefore most survivors deal and train cutting when using knives early on.

As a result, most survivors train cutting only by using knives."

and he is right. If this is intentional please ignore this pull request

or if this is not intentional, like KA101 suggested, this will (i think) make knife-type weapons act similar to spear-type weapons, where they both train and use only pierce skill.

@aierce

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2015

Yeah line 2126

if (p.weapon.has_flag("SPEAR") || (p.weapon.has_flag("STAB") && stab_dam > cut_dam))

pretty much proves that this behavior is intentional and not a bug

@aierce aierce closed this Feb 2, 2015

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2015

I don't understand how that line proves the behavior (stabbing weapons giving cutting exp) is intended.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Feb 2, 2015

The problem is that as the character's cutting skill rises, their cutting damage increases so that eventually it's pretty much impossible for them to do more stabbing than cutting damage, so their piercing skill stops increasing after that point.

What we need is for piercing skill to be improved by using piercing weapons, full stop. Having the ability to improve the skill based off hoping your cutting skill is sufficiently low to allow random chance to give piercing some XP is silly, and it's basically broken the piercing skill.

@aierce

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2015

Spear weapons only improves piercing damage, wooden and knife spears are easy to make. KA101 also suggest on the forum to turn off cutting skill experience in the @ character menu with the space bar

@KA101 KA101 reopened this Feb 2, 2015

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2015

Rivet's right: stabbing needs to be equal to cutting when a weapon does both. I'm willing to give this a shot and see how it works.

@KA101 KA101 self-assigned this Feb 2, 2015

@KA101 KA101 merged commit 6d0b388 into CleverRaven:master Feb 3, 2015

1 check passed

default
Details
@bookofguns

This comment has been minimized.

Copy link

commented Feb 12, 2015

Um could there be a stance with melee weapons to dictated rather the player is in a "Slashing" stance, "Bashing" stance, or "Stabbing" stance. Along with a default that just rolls the original code?

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2015

Not impossible, but I'm thinking it's not worth the trouble.

@aierce aierce deleted the aierce:patch-3 branch Sep 28, 2018

@aierce aierce restored the aierce:patch-3 branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.