Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upwild stab at, stabbing weapon gaining cutting experience bug #11092
Conversation
This comment has been minimized.
This comment has been minimized.
|
even if this doesn't fix the experience bug, this is still a valid bug fix, i think, maybe there are multiple bugs contributing to this problem |
This comment has been minimized.
This comment has been minimized.
|
OK Coolthulhu said on the forum: "It works like this: Every knife-type weapon deals "equally random" amount of cutting and piercing. As in, if it deals 1d10 cutting, it also deals 1d10 piercing. Most survivors get cutting quicker, because there are more (good) weapons that do this AND because cutting damage has a lower penalty from low skills. As a result, most survivors train cutting only by using knives." and he is right. If this is intentional please ignore this pull request or if this is not intentional, like KA101 suggested, this will (i think) make knife-type weapons act similar to spear-type weapons, where they both train and use only pierce skill. |
This comment has been minimized.
This comment has been minimized.
|
Yeah line 2126 if (p.weapon.has_flag("SPEAR") || (p.weapon.has_flag("STAB") && stab_dam > cut_dam)) pretty much proves that this behavior is intentional and not a bug |
aierce
closed this
Feb 2, 2015
This comment has been minimized.
This comment has been minimized.
|
I don't understand how that line proves the behavior (stabbing weapons giving cutting exp) is intended. |
This comment has been minimized.
This comment has been minimized.
|
The problem is that as the character's cutting skill rises, their cutting damage increases so that eventually it's pretty much impossible for them to do more stabbing than cutting damage, so their piercing skill stops increasing after that point. What we need is for piercing skill to be improved by using piercing weapons, full stop. Having the ability to improve the skill based off hoping your cutting skill is sufficiently low to allow random chance to give piercing some XP is silly, and it's basically broken the piercing skill. |
This comment has been minimized.
This comment has been minimized.
|
Spear weapons only improves piercing damage, wooden and knife spears are easy to make. KA101 also suggest on the forum to turn off cutting skill experience in the @ character menu with the space bar |
KA101
reopened this
Feb 2, 2015
This comment has been minimized.
This comment has been minimized.
|
Rivet's right: stabbing needs to be equal to cutting when a weapon does both. I'm willing to give this a shot and see how it works. |
KA101
self-assigned this
Feb 2, 2015
KA101
merged commit 6d0b388
into
CleverRaven:master
Feb 3, 2015
1 check passed
This comment has been minimized.
This comment has been minimized.
bookofguns
commented
Feb 12, 2015
|
Um could there be a stance with melee weapons to dictated rather the player is in a "Slashing" stance, "Bashing" stance, or "Stabbing" stance. Along with a default that just rolls the original code? |
This comment has been minimized.
This comment has been minimized.
|
Not impossible, but I'm thinking it's not worth the trouble. |
aierce commentedFeb 2, 2015
a wild stab at the bug where stab weapon gain cut experience