Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color clothing items depending on damage value. (Inventory, Pickup, etc) #11167

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
6 participants
@OzoneH3
Copy link
Member

commented Feb 7, 2015

Proper item coloring in V menu.
Clothing damage colors taken from armor_sort().

@Barhandar

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2015

🌈

Translation: I find this change to severely interfere with existing color-coding, which it partially overlaps with - of suitable weapon-ammo pairs in green, of damaged radioactive items in light green, and of spoilable food in cyan, yellow, and brown, and consider it unnecessary, in part because of existence of '+' clothing relayering menu, which is already compatible with coloring items depending on their damage.
Also, inventory would look like a bloody rainbow with it.

@narc0tiq

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2015

I'm with @Barhandar on this one. Too much color for too little gain.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Feb 7, 2015

Also remember that some of us have a hard time with colors. Adding lots more colors only makes stuff harder for us to read.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2015

Yeah, skittles* are good in moderation but get old in quantity. Afraid this one isn't gonna merge. Thanks anyway. :-(

*Taste the rainbow!

@KA101 KA101 closed this Feb 7, 2015

@OzoneH3

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2015

What about something like this:

Another less rainbowy aproach. Less space used for the itemname, can probably trim down (fits) as well as other modifiers.

You can see on one glance what item is damaged. Its also easier to see what the actual itemname is without having to read the damage type first, especially in a long worn list with longer and shorter damage texts.

This could also just be an option to use for a different way of displaying stuff.

@Nevets-

This comment has been minimized.

Copy link

commented Feb 9, 2015

You could compress the damage indicators down to two characters like this:
++ Reinforced (Blue)
|| Undamaged (Dark Green)
|\ Ripped (Light Green)
|. Torn (Yellow)
\. Shredded (Light Red)
.. Tattered (Dark Red)
With the spaces instead of periods, and then everything stays lined up.

@narc0tiq

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2015

I like both of those ideas. Like a smaller version of the limb HP display for items.

@OzoneH3 OzoneH3 deleted the OzoneH3:color_item_damage branch Feb 9, 2015

@OzoneH3 OzoneH3 referenced this pull request Feb 9, 2015

Closed

[WIP][CR] Shorter item status and coloring #11190

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.