Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTranslatable color codes #11174
Conversation
kevingranade
added some commits
Feb 8, 2015
KA101
self-assigned this
Feb 8, 2015
KA101
reviewed
Feb 8, 2015
| } | ||
| mvwprintz(win, row, column, get_note_color(color_pair.first), | ||
| color_description.c_str()); | ||
| column += pair_width; |
This comment has been minimized.
This comment has been minimized.
KA101
Feb 8, 2015
Contributor
This (well, something in this code) ends up leaving a trailing comma after the last entry. Not a dealbreaker but someone will probably complain.
This comment has been minimized.
This comment has been minimized.
DavidKeaton
Feb 8, 2015
Contributor
you could use the same method in item description (simple boolean when describing recipes items can be made into).
KA101
merged commit f47af30
into
CleverRaven:master
Feb 8, 2015
Ishindri
referenced this pull request
Feb 8, 2015
Closed
Add custom map symbol colors to in-game help #9515
kevingranade
deleted the
kevingranade:translatable-color-codes
branch
Mar 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedFeb 8, 2015
The key parts are that the color codes at the bottom of the map help menu should be translatable now (?5), and when adding a note to the map it displays help text giving you said color codes.