Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V-menu style filters for advanced inventory menu. #11235

Merged
merged 3 commits into from Feb 14, 2015

Conversation

Projects
None yet
5 participants
@OzoneH3
Copy link
Member

commented Feb 13, 2015

Requested from: #11215

Just not sure where to put the info text how to use the filter options.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Feb 13, 2015

Just not sure where to put the info text how to use the filter options.

How about the Advanced Inventory help screen?

@OzoneH3

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2015

Yeah, don't know. That screen is more about keybindings and it's quite a bit of text.

@Ishindri

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2015

Thank you, Ozone!

In the V-menu, when you go into the filter field, the description of whatever item you were looking at is temporarily replaced by the filter instructions. Could something like that be done with the log field at the top of the advanced inventory menu?

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2015

Clarify: -pipe,chunk,steel excludes all three?

@OzoneH3

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2015

Hmm, it used to but must have been changed. Updated the text.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2015

Uh, I didn't know and wasn't sure from the text, so asked--better to get the instructions right on the first try.

@narc0tiq

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2015

AFAIK, every comma-separated part is separate from every other part, so
"-pipe,chunk,steel" should mean something like "show me only things that
match 'chunk' or 'steel', but not 'pipe'". I'm not 100% sure if it's an
"or" or an "and".

On Sat, Feb 14, 2015 at 1:24 AM, KA101 notifications@github.com wrote:

Uh, I didn't know and wasn't sure from the text, so asked--better to get
the instructions right on the first try.


Reply to this email directly or view it on GitHub
#11235 (comment)
.

@KA101 KA101 self-assigned this Feb 14, 2015

@KA101 KA101 merged commit f89a702 into CleverRaven:master Feb 14, 2015

1 check passed

default
Details

@OzoneH3 OzoneH3 deleted the OzoneH3:adv_inv_v_filter branch Feb 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.