Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTSM fix: now rewarding for Cannibals #11300
Conversation
KA101
reviewed
Feb 17, 2015
| } if (has_trait("SPIRITUAL") && book->has_flag("INSPIRATIONAL")) { | ||
| fun_bonus = 15; | ||
| } else if ( has_trait("SPIRITUAL") && book->has_flag("INSPIRATIONAL") ) { | ||
| fun_bonus = 15; |
This comment has been minimized.
This comment has been minimized.
KA101
Feb 17, 2015
Contributor
Uh, this is the religious texts; the cannibal cookbook is the next one up. I'm pretty sure To Serve Man isn't considered Inspirational, so I'm at a loss for why the need to else this if.
This comment has been minimized.
This comment has been minimized.
|
I must've broken this when I fixed religious books. |
This comment has been minimized.
This comment has been minimized.
|
That's as may be, but I'm not at all sure how this fixes the problem. TSM isn't INSPIRATIONAL so it shouldn't be triggering the if here. |
Gabriel-SE
force-pushed the
Gabriel-SE:tsm-fix
branch
to
0e85484
Feb 18, 2015
This comment has been minimized.
This comment has been minimized.
|
If the book is TSM, without else if the first cannibal check will add correct morale bonus but the last else will also be executed because TSM isn't inspirational. |
This comment has been minimized.
This comment has been minimized.
|
OK, that'll do. Thanks. |
Gabriel-SE commentedFeb 17, 2015
And a few code style changes