TSM fix: now rewarding for Cannibals #11300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } if (has_trait("SPIRITUAL") && book->has_flag("INSPIRATIONAL")) { | ||
| fun_bonus = 15; | ||
| } else if ( has_trait("SPIRITUAL") && book->has_flag("INSPIRATIONAL") ) { | ||
| fun_bonus = 15; |
There was a problem hiding this comment.
Uh, this is the religious texts; the cannibal cookbook is the next one up. I'm pretty sure To Serve Man isn't considered Inspirational, so I'm at a loss for why the need to else this if.
|
I must've broken this when I fixed religious books. |
|
That's as may be, but I'm not at all sure how this fixes the problem. TSM isn't INSPIRATIONAL so it shouldn't be triggering the if here. |
And a few code style changes
|
If the book is TSM, without else if the first cannibal check will add correct morale bonus but the last else will also be executed because TSM isn't inspirational. |
|
OK, that'll do. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a few code style changes