Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes color tags and wide display bugs #11312

Merged
merged 1 commit into from Feb 27, 2015

Conversation

Projects
None yet
4 participants
@bkentel
Copy link
Contributor

commented Feb 18, 2015

  • Fixes some fallout w.r.t the live view from the recent item display changes, and properly truncates item names.
  • Fixes wrong window size / offset for the live view in wide menu mode.
  • Fixes a tiny bug in print_colored_text where empty strings were printed.
  • Tiny tweak to trim_and_print.
  • Some light cleanup of live_view.
@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2015

Pretty sure I can't test the mouse stuff, sorry. :-/

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2015

Did you happen to widen the display for terrain view? Leftover stuff from inventory and the like gets annoying.

@bkentel

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2015

@DavidKeaton Do you have a screencap of what you mean? Maybe I fixed it, but I'm not sure.

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2015

I can get you one in a bit, out ATM.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Feb 21, 2015

I need a better description of what this is supposed to do, in other words how do I reproduce the problem so I can verify it's fixed?

@bkentel

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2015

A picture is worth a thousand words; notice the fixed border and tags.
side_bar_before
side_bar_after

@KA101

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2015

Hmm. KA101 notices the yen sign in place of the (back)slash That's a font issue, I take it?

@bkentel

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2015

Yeah, font and windows legacy locale side effect; only affects "" though (still pretty damn annoying and ugly though).

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2015

That stuff is CP6508 DOS right? (The yen error)

@bkentel

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2015

@DavidKeaton it's one side effect of using "ja" as your legacy locale on windows and cata being built as a as multi-byte (not unicode aware) program (fonts also complicate things).

live_view::live_view() : compact_view(false), w_live_view(NULL),
enabled(false), inuse(false), last_height(-1)
namespace {
constexpr int START_LINE = 1;

This comment has been minimized.

Copy link
@kevingranade

kevingranade Feb 27, 2015

Member

hah! This we can agree on :D 👍

constexpr int START_LINE = 1;
constexpr int START_COLUMN = 1;

void print_items(WINDOW *const w, const map_stack &items, int &line)

This comment has been minimized.

Copy link
@kevingranade

kevingranade Feb 27, 2015

Member

Not your fault, and I'd prefer to keep this a bugfix anyway, but I'm pretty sure there's another piece of code that does the exact same thing elsewhere.

@kevingranade kevingranade merged commit 33d4c01 into CleverRaven:master Feb 27, 2015

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

@bkentel bkentel deleted the bkentel:live-view-fix branch Mar 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.