Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upI18n friendly effects #11374
Conversation
kevingranade
added some commits
Feb 23, 2015
KA101
reviewed
Feb 23, 2015
| @@ -251,7 +251,7 @@ | |||
| "symbol": "(", | |||
| "color": "dark_gray", | |||
| "name": "Dual Nail Turret", | |||
| "name_plural": "Nail Turrets", | |||
| "name_plural": "Dual Nail Turrets", | |||
This comment has been minimized.
This comment has been minimized.
KA101
assigned
KA101
and unassigned
KA101
Feb 23, 2015
This comment has been minimized.
This comment has been minimized.
|
Misclick there. |
This comment has been minimized.
This comment has been minimized.
|
Can lowercase if that's the way we want to go.
|
This comment has been minimized.
This comment has been minimized.
|
Well, Rivet lowercased the rest of 'em a while ago, and that is generally the DDA style (names, such as Tesla and Granade, retain uppercase). |
KA101
self-assigned this
Feb 26, 2015
This comment has been minimized.
This comment has been minimized.
|
Merging as-is because string freeze. |
KA101
merged commit 8792ce1
into
CleverRaven:master
Feb 26, 2015
1 check passed
default
Details
kevingranade
deleted the
kevingranade:i18n-friendly-effects
branch
Mar 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedFeb 23, 2015
Consolidated the per-limb effect description messages as per Wuzzy's request: http://smf.cataclysmdda.com/index.php?topic=4403.msg211905#msg211905