Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged oter_t from using bools to usng bitset. #11446
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looks OK to me. |
BevapDin
reviewed
Mar 3, 2015
| @@ -22,6 +22,27 @@ struct overmap_spawns { | |||
| int max_population; | |||
| int chance; | |||
| }; | |||
| //terrain flags enum! this is for tracking the indices of each flag. | |||
| //is_asphalt, is_building, is_subway, is_sewer, is_ants, | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Angular-Angel
Mar 3, 2015
Author
Contributor
To make them easier to find for people reading through the code. I'll probabl remove the default argument from the set_flag function, but I'll leave that until the next pull request.
This comment has been minimized.
This comment has been minimized.
BevapDin
Mar 3, 2015
Contributor
They are listed again right below it as part of the enum definition, why repeat them?
If one can read them in the comment, one can also read them in the actual code. Do you really think someone sees them in the comment but is unable to find them in the actual definition? And I usually use the search-in-document function (or similar) of the editor when I need to find some definition.
This comment has been minimized.
This comment has been minimized.
KA101
Mar 3, 2015
Contributor
Agreed that in this context the comment-listing is unhelpful. Something along the lines of "add new terrain flags to this list" (presuming that that is in fact the case) would likely be more helpful.
This comment has been minimized.
This comment has been minimized.
Angular-Angel
Mar 4, 2015
Author
Contributor
Oh, that's because I wrote the comment before I wrote the Enum, and never rewrote the comment.
kevingranade
merged commit 166fe2f
into
CleverRaven:master
Mar 21, 2015
1 check failed
Angular-Angel
deleted the
Angular-Angel:WorldgenRevisions
branch
Mar 21, 2015
This comment has been minimized.
This comment has been minimized.
|
Oh, cool. I had forgotten to go back and update it for compatibility with 0.C, but it looks like you took care of that. Thank you. |
Angular-Angel commentedMar 2, 2015
This is just the changes to switch over to the bitset. I'm not entirely sure I did the whole Pull Request propery, so you should probably take a close look at it. It's prety short, so it shouldn't be too much trouble.