Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zlevels field function update #11472

Merged
merged 5 commits into from Mar 21, 2015

Conversation

Projects
None yet
4 participants
@Coolthulhu
Copy link
Contributor

commented Mar 6, 2015

Includes #11445

Changes map functions related to fields to tripoints. Old invocations are handled by overloads. Overloads construct tripoints.
As far as I know, most of the performance penalty from field comes from fires iterating over all items. If this is not true and fields should retain all their performance, I'll add back the 2D functions in their current form.

For the often-used functions (such as has_flag) I keep their original functions for now, with the tripoint overloads being totally separate. This wouldn't be very maintainable in long term, but this is just a temporary measure - I intend to first create all the overloads for map functions, then remove the invocations of their 2D versions, then finally remove the 2D versions totally.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2015

Can't wait to see it in action!

@Coolthulhu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2015

Sorry to disappoint, but this is purely a technical change. Actual z-level fields like tall fires and clouds of smoke require this change, but are themselves a separate thing.

The entire first "batch" of PRs is just technical stuff.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2015

Still, that first batch is necessary for clouds of smoke to happen :)

Merge branch 'master' into zlev-field-basic
Conflicts:
	src/game.cpp

@kevingranade kevingranade merged commit 1565fb4 into CleverRaven:master Mar 21, 2015

@Coolthulhu Coolthulhu deleted the cataclysmbnteam:zlev-field-basic branch Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.