Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTranslation update 0.C #11481
Conversation
BevapDin
reviewed
Mar 8, 2015
View changes
src/newcharacter.cpp
Outdated
| wrefresh(w_scenario); | ||
|
|
||
| werase(w_profession); | ||
| mvwprintz(w_profession, 0, 0, COL_HEADER, _("Profession: ")); | ||
| wprintz (w_profession, c_ltgray, u->prof->gender_appropriate_name(u->male).c_str()); | ||
| wprintz (w_profession, c_ltgray, _(u->prof->gender_appropriate_name(u->male).c_str())); |
This comment has been minimized.
This comment has been minimized.
BevapDin
Mar 8, 2015
Contributor
Are you sure this is required? It seems the names are already translated via pgettext in profession::load_profession.
This comment has been minimized.
This comment has been minimized.
kevingranade
Mar 8, 2015
Author
Member
You're right, scenario was untranslated, but profession was fine, will revert.
BevapDin
reviewed
Mar 8, 2015
View changes
src/veh_interact.cpp
Outdated
| @@ -1826,7 +1826,7 @@ void veh_interact::display_details( const vpart_info *part ) | |||
| if ( part->fuel_type != "NULL" ) { | |||
| fold_and_print(w_details, line+4, col_1, ( vertical_menu ? column_width : details_w ), c_white, | |||
| _("Charge: <color_ltgray>%s</color>"), | |||
| part->fuel_type.c_str()); | |||
| _(part->fuel_type.c_str())); | |||
This comment has been minimized.
This comment has been minimized.
BevapDin
Mar 8, 2015
Contributor
fuel_type is actually an identifier (an ammo type). In veh_interact::do_refill, it's translated like this:
ammo_name( vehicle_part_types[...].fuel_type ).c_str()Some parts of the code seem to think it's an item type id.
kevingranade
added some commits
Mar 7, 2015
kevingranade
force-pushed the
kevingranade:translation-update-0.C
branch
to
79e8916
Mar 8, 2015
This comment has been minimized.
This comment has been minimized.
|
Updated based on BevapDin's comments, thanks! |
This comment has been minimized.
This comment has been minimized.
|
We're getting so much closer to 0.C, it's wonderful! I'm looking forward to the end of this freeze. |
Rivet-the-Zombie
self-assigned this
Mar 8, 2015
Rivet-the-Zombie
added a commit
that referenced
this pull request
Mar 8, 2015
Rivet-the-Zombie
merged commit 6621034
into
CleverRaven:master
Mar 8, 2015
1 check passed
default
Details
This comment has been minimized.
This comment has been minimized.
|
Italian, Argentinian, Greek on transifex too. |
kevingranade
deleted the
kevingranade:translation-update-0.C
branch
Mar 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedMar 8, 2015
Several updates to language handling as per http://smf.cataclysmdda.com/index.php?topic=4403.msg225130#msg225130