Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix clothing removing encumbrance #11742
Conversation
Coolthulhu
added some commits
Mar 22, 2015
kevingranade
self-assigned this
Mar 22, 2015
kevingranade
merged commit 1f07c7b
into
CleverRaven:master
Mar 22, 2015
1 check passed
default
Details
This comment has been minimized.
This comment has been minimized.
Coolthulhu
deleted the
cataclysmbnteam:clothing-encumbrance-order
branch
Apr 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Coolthulhu commentedMar 22, 2015
Closes #11722 and #11739
The bug was a result of fitting non-zero encumbrance items decreasing the part encumbrance and then checking if it went below 0 instead of checking if
(this_gear's_encumbrance - 1)isn't below 0.As a result, fitting items with encumbrance between 0 and 10 would counter the encumbrance caused by items before them (item order matters).