[CR] Home Improvement Megastore

[PropaneSoup]

From #11851, I've got the layout mostly finalized, but I haven't touched any items spawns yet. I'm making this public because I really can't do much testing of it right now. Upon loading a game it gives me a json error of bad mapgen terrain. I'm hoping someone here can point out the comma that I've stupidly been missing somewhere.

Other than that, thoughts on its layout? Suggestions?

[sparr]

I tried to figure it out. As near I can tell, it's complaining that "t_wall_h" doesn't appear in termap, but it still complains even if I change that row of terrain to all t_pavement.

[BevapDin]

There is no mapping defined for C, the game does not know what terrain to put there and terrain is mandatory.

[sparr]

is this the root cause of the failure? the json loading error complains about the line "------------------------" which appears in a later mapgen object.

[PropaneSoup]

I put in a t_floor for all my pieces of furniture. Probably was an issue, but not the one I was talking about.

[BevapDin]

Nope, there is no terrain mapping for the letter C, what mapping you defined for any other letter does not matter at all. Look at the terrain object below, it contains mappings for _ . , r - | + d W but not for C, and also not for ^, how is the game supposed to known what terrain those places should have? As I said before, the terrain must be specified for every square, furniture and the other stuff is optional, but you need a terrain everywhere.

@sparr The mapgen objects are loaded later (they need to know the other stuff for valid terrain etc. ids) and may be loaded in a different order. An error with that message is thrown when the terrain mapping contains a letter that is not mapped. But there is bug: the error is throw from the wrong json object and that makes the line wrong, but this only affects the display of the error.

[sparr]

Good to know, re the bug.

However, I think you're on the wrong track. Not having a terrain mapping for the letter C might be an error, but it's not the error that throws this specific exception.

            pjo = jo.get_object("terrain");
            for( const auto &key : pjo.get_member_names() ) {
                if( pjo.has_string( key ) ) {
                    const auto tmpval = pjo.get_string( key );
                    const auto iter = termap.find( tmpval );
                    if( iter == termap.end() ) {
                        jo.throw_error( "Invalid terrain", key );
                    }

it looks like the "Invalid terrain" error specifically means that there IS a defined terrain mapping for a letter, but that the mapped string doesn't exist in termap[]

[BevapDin]

Indeed, you are right. There is no t_door_clear_c terrain.

[PropaneSoup]

Hm, I think I'm missing something. I've assigned terrain for my furniture and replaced the t_door_clear_c and a vending machine that also didn't exist and it's still giving me this error. I've checked all of my terrain with terrain.json, and they're all there.

[sparr]

So not everyone has to reproduce it...

    src/mapgen.cpp:1200 Bad JSON mapgen, discarding:
  line 1:1: Invalid terrain


^
{
            "rows": [
            "------------------------",

[drbig]

@sparr @PropaneSoup have the same issue. And then a couple more lines like it. I'll await more commits then :)

[BevapDin]

It's t_floor, not f

[KA101]

And look at those tabs...

[vache]

This means there will be a minimum of 10 and max of 20 per overmap. That should probably be reduced to something like [1,5]

[PropaneSoup]

Oh yea, that's is just for testing purposes so I don't have to go hunting around overmaps for one.

[vache]

I figured it was something along those lines, but I just wanted to make sure because we've had problems with specials with high minimum occurrences stepping on other specials in the past.

[vache]

A couple things I've noticed, structures that have walls that butt right up to the edge will look pretty ugly if they are ever placed next to each other. It's not as big a problem with overmap specials as opposed to normal buildings because specials are placed with a certain density so the chances of two butting up against each other is low, but it's something to keep in mind, especially once mapgen gets worked out to allow specials inside cities.

These buildings usually have large semi-outdoor garden areas with chain link fences for landscaping and garden supplies. I don't know if it's possible to have a roofed in area with chain link fence walls, but that might be good to add. Also, a lot of buildings lack back areas with offices and loading bays and dumpsters and things like that.

[PropaneSoup]

Thanks for the tips on building gen with walls. I'll keep that in mind. I agree with you on the backroom and loading bay areas too, so the building is now a 2x3, with the extra rooms in the back.

I don't know if it's possible to have a roofed in area with chain link fence walls

I had considered them, and this was my reason for not including them in the layout.

[sparr]

Why does the chain link fence area need to be roofed? Make a chain link fence material yard and if you need roofed areas put in some 3-walled buildings inside?

[facepalm]

Sort of unrelated question: is there a way to spawn these sorts of maps in-game?

I've considered doing some map work myself, but aside from standing back and admiring my ascii drawings I don't know of any way to test them directly.

[sparr]

You can spawn singles of them via the debug menu. Go into keybinds and assign a key to debug, then hit debug and map editor and map gen. You can't do the spiffy multi-tile overmap special stuff exactly, but you can do 1/4 of this at a time.

[facepalm]

Flippin' sweet! Thanks!

[KA101]

Chain-fence walls & roofed tiles: you can't build 'em personally but so far as I know there's no reason you can't set the tiles to be roofed concrete floor (may need to make that terrain? not sure) or wev in the mapgen. If need be, include a few single-tile walls in the area as support columns.

IIRC collapses only happen when terrain gets destroyed, so I wouldn't expect the garden center roof to just collapse. :-/

[PropaneSoup]

Added in the garden area, turns out chainlink fences already support roofs :P

All thats left now are the Monster Spawns and water in the toilets. How does the layout look? Spawns too low, too high?
I did throw in some "handyman" CBMs, as some rare spawns, thoughts on those? Any CBMs or tools that I missed?

[vache]

I'm not sure how I feel about including CBMs there. At this point in the world, CBMs are supposed to be a top of the line thing only available to the richest people, the government, and large companies. The only way I would see including them would be if they were locked up very tight, sort of like the CBMs in labs where you have to open the reinforced glass tubes to get at them.

[sparr]

IRL, Home Depot carries small pieces of electronics that cost thousands of dollars, in "simple" locked glass display cases. Infrared cameras come to mind.

[drbig]

Including CBMs sounds to me like pushing it way overboard. The point
is still the raw materials. Little tools, less zombies, no CBMs - that's
how I see it.

[Zireael07]

I'd remove the CBMs too. Another branch of the store chain could stock small pieces of electronics, let's make this one about building.

[drbig]

@sparr That could be a thing to ponder later (when we get proper industrial zones, or at least building supply lots (as discussed in #11851)). Though CBMs would still be too much to put there imo.

[PropaneSoup]

Ok, I thought CBMs were a little more in the populace, guess my lore is a little rusty. I'll take 'em out of the spawns.

[PropaneSoup]

Ok, this should be good for review.

One thing I did notice is that I seem to have no control over the zombie spawn. Using the MALL_GROUP zombie group, composed mostly of regular zombies, I was getting hoards of smokers, tough zombies and shocker brutes. Perhaps I'm missing something?

[BevapDin]

You should not repeat the definition of this monster group (all json definition are global, it does not matter which file they are declared in), it is already defined in data/json/mapgen/mall.json.

The definition there contains

"replace_monster_group" : true,
"new_monster_group_id" : "GROUP_ZOMBIE_MID",
"replacement_time" : 0

Replacement time 0 means it's replaces right after the first turn, the replacement group "GROUP_ZOMBIE_MID" is used instead, which makes the group definition pretty much useless. Either increase the replacement time (it's apparently in days) there, or use another monster group.

[PropaneSoup]

Ahh, that explains it. Unless there are any objections, I think I'll increase that replacement time to probably 14.

[qbradq]

What happened to the larger shopping carts idea? That was the part I was most excited for :)