Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color templates #11878

Merged
merged 3 commits into from Apr 3, 2015

Conversation

Projects
None yet
7 participants
@OzoneH3
Copy link
Member

commented Apr 1, 2015

Added color template support. Templates are located in data/raw/color_templates/*.json.
Removed No Bright Option and colors. Added a No Bright template.

Custom colors are now displayed with their color name.

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2015

I wub u

@tivec

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2015

Brilliant! This will be awesome :) Now I just wish we had more colors to work with, but I guess that's a limitation with the engine?

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2015

@tivec: Not engine per se, terminal on some OSes.

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2015

@Zireael07 correct. The highest a standard terminal running ncurses can grab is 256 color combos.

@@ -761,13 +761,6 @@ void initOptions()
);

////////////////////////////GRAPHICS/////////////////////////
OPTIONS["NO_BRIGHT_BACKGROUNDS"] = cOpt("graphics", _("No bright backgrounds"),
_("If true, bright backgrounds are not used - some consoles are not compatible."),
false

This comment has been minimized.

Copy link
@KA101

KA101 Apr 2, 2015

Contributor

Hmm. Just for safety's sake, how will this affect bright-background-incompatible consoles--will they be able to access the menu and enable the template (and then later modify it, in the event that the user happens to need/want modified colors)?

This comment has been minimized.

Copy link
@narc0tiq

narc0tiq Apr 2, 2015

Contributor

The incompatibility is that some terminal emulators understand the bright
background flag as bold, to the best of my knowledge. That won't prevent
anyone from accessing the options menu.

On Thu, Apr 2, 2015 at 5:06 AM KA101 notifications@github.com wrote:

In src/options.cpp
#11878 (comment)
:

@@ -761,13 +761,6 @@ void initOptions()
);

 ////////////////////////////GRAPHICS/////////////////////////
  • OPTIONS["NO_BRIGHT_BACKGROUNDS"] = cOpt("graphics", _("No bright backgrounds"),
  •                                        _("If true, bright backgrounds are not used - some consoles are not compatible."),
    
  •                                        false
    

Hmm. Just for safety's sake, how will this affect
bright-background-incompatible consoles--will they be able to access the
menu and enable the template (and then later modify it, in the event that
the user happens to need/want modified colors)?


Reply to this email directly or view it on GitHub
https://github.com/CleverRaven/Cataclysm-DDA/pull/11878/files#r27628344.

This comment has been minimized.

Copy link
@KA101

KA101 Apr 2, 2015

Contributor

OK, that's good to know. I'm likely to have to run today but hope to get the net up in Pittsburgh, so hopefully will be able to merge again there tonight.

(Otherwise, more equine-mutcat work, so it's not all bad.)

@kevingranade kevingranade self-assigned this Apr 3, 2015

@kevingranade kevingranade merged commit 890d3c0 into CleverRaven:master Apr 3, 2015

1 check passed

default
Details

@OzoneH3 OzoneH3 deleted the OzoneH3:color_templates branch Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.