Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upColor templates #11878
Conversation
OzoneH3
added some commits
Apr 1, 2015
This comment has been minimized.
This comment has been minimized.
|
I wub u |
This comment has been minimized.
This comment has been minimized.
|
Brilliant! This will be awesome :) Now I just wish we had more colors to work with, but I guess that's a limitation with the engine? |
This comment has been minimized.
This comment has been minimized.
|
@tivec: Not engine per se, terminal on some OSes. |
This comment has been minimized.
This comment has been minimized.
|
@Zireael07 correct. The highest a standard terminal running ncurses can grab is 256 color combos. |
KA101
reviewed
Apr 2, 2015
| @@ -761,13 +761,6 @@ void initOptions() | |||
| ); | |||
|
|
|||
| ////////////////////////////GRAPHICS///////////////////////// | |||
| OPTIONS["NO_BRIGHT_BACKGROUNDS"] = cOpt("graphics", _("No bright backgrounds"), | |||
| _("If true, bright backgrounds are not used - some consoles are not compatible."), | |||
| false | |||
This comment has been minimized.
This comment has been minimized.
KA101
Apr 2, 2015
Contributor
Hmm. Just for safety's sake, how will this affect bright-background-incompatible consoles--will they be able to access the menu and enable the template (and then later modify it, in the event that the user happens to need/want modified colors)?
This comment has been minimized.
This comment has been minimized.
narc0tiq
Apr 2, 2015
Contributor
The incompatibility is that some terminal emulators understand the bright
background flag as bold, to the best of my knowledge. That won't prevent
anyone from accessing the options menu.
On Thu, Apr 2, 2015 at 5:06 AM KA101 notifications@github.com wrote:
In src/options.cpp
#11878 (comment)
:@@ -761,13 +761,6 @@ void initOptions()
);////////////////////////////GRAPHICS/////////////////////////
- OPTIONS["NO_BRIGHT_BACKGROUNDS"] = cOpt("graphics", _("No bright backgrounds"),
_("If true, bright backgrounds are not used - some consoles are not compatible."),falseHmm. Just for safety's sake, how will this affect
bright-background-incompatible consoles--will they be able to access the
menu and enable the template (and then later modify it, in the event that
the user happens to need/want modified colors)?—
Reply to this email directly or view it on GitHub
https://github.com/CleverRaven/Cataclysm-DDA/pull/11878/files#r27628344.
This comment has been minimized.
This comment has been minimized.
KA101
Apr 2, 2015
Contributor
OK, that's good to know. I'm likely to have to run today but hope to get the net up in Pittsburgh, so hopefully will be able to merge again there tonight.
(Otherwise, more equine-mutcat work, so it's not all bad.)
OzoneH3 commentedApr 1, 2015
Added color template support. Templates are located in data/raw/color_templates/*.json.
Removed No Bright Option and colors. Added a No Bright template.
Custom colors are now displayed with their color name.