Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query_yn for some Unicode languages #11886

Merged
merged 3 commits into from Apr 3, 2015

Conversation

Projects
None yet
3 participants
@VlasovVitaly
Copy link
Contributor

commented Apr 2, 2015

Fix issue #11877
pot file updated too.

@kevingranade kevingranade self-assigned this Apr 3, 2015

@kevingranade kevingranade merged commit e00f4ca into CleverRaven:master Apr 3, 2015

1 check passed

default
Details
@BevapDin

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2015

@VlasovVitaly Translating the four letters (y/n/Y/N) separately and combining the translations into the displayed string would theoretically allow any characters (single Unicode code point) to be used.

That means adding translations for "letter for yes (uppercase)", "letter for yes (lowercase)", "letter for no (uppercase)" and "letter for no (lowercase)" (using a translation context).

The current code can only uppercase ASCII characters, that would be avoid as well. Of course it requires more work from the translators, so would this be an acceptable solution?

@VlasovVitaly

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2015

I thinking about this method and found couple of major problems:

  1. As you noticed, working with Uppercase/Lowercase is confusing. This can be resolved by adding good comments for translators.
  2. I can't image what happens when only one letter will be translated and other is not.
  3. User need to change keyboard layout to press y/n directly in all non-latin languages. This can be possible resolved by adding keyboard mapping list. Russian example '' => 'д' => 'y', 'н' => 'n'. Most awesome thing is we can use this mapping in any input context. So anyone can use own language key bindings. But i guess this will be broken for oriental languages.

@VlasovVitaly VlasovVitaly deleted the VlasovVitaly:try-fix-11877 branch Apr 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.