Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Noodles of Doom's Laundromat #12271

Merged
merged 3 commits into from May 12, 2015

Conversation

Projects
None yet
4 participants
@jokermatt999
Copy link
Contributor

commented May 2, 2015

All credit to Noodles of Doom. Uploaded since they don't 'gitgud' :)

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented May 3, 2015

Yus, this should be fun. o3o

Additionally, for clarification I'll link back to the forum thread: http://smf.cataclysmdda.com/index.php?topic=10187.0

@Coolthulhu Coolthulhu self-assigned this May 3, 2015

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented May 3, 2015

Something is wrong with the item spawns. Bleach either doesn't spawn at all or spawns in huge batches, easily 10 gallons on a single tile.

@Coolthulhu Coolthulhu removed their assignment May 3, 2015

"type" : "item_group",
"id" : "laundromat_bleach",
"items" : [
["bleach", 50]

This comment has been minimized.

Copy link
@chaosvolt

chaosvolt May 3, 2015

Contributor

A lack of either a charges-min/max or count-min/max here is presumably the cause of massive amounts of bleach.

@Laan-Rose

This comment has been minimized.

Copy link

commented May 3, 2015

Sorry for the goof-up, folk ups :). I think I fixed the problem:

Changing the "chance" and "repeat" values of line 253...
{ "item": "laundromat_bleach", "chance": 75, "x": [6,12], "y": [19,20], "repeat": [1,2] },

...to this seems to fix the problem. Spawns are now more like 1-2 gallons of bleach on about 1-2 racks.
{ "item": "laundromat_bleach", "chance": 30, "x": [6,12], "y": [19,20], "repeat": [4,8] },

Also, thanks Jokermatt999 for PR-ing this- I'm not very git-savvy to say the least, so have my thanks for going out and putting this on Github :)

@Coolthulhu Coolthulhu self-assigned this May 3, 2015

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented May 3, 2015

One thing more: it should also be less common. At weight 2, cities can easily have 4 'mats with barely any distance between them.

@Coolthulhu Coolthulhu removed their assignment May 3, 2015

jokermatt999 added some commits May 12, 2015

@jokermatt999

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2015

Made those requested changes. Let me know if issues persist?

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented May 12, 2015

Good timing - I just started my testing run

@Coolthulhu Coolthulhu self-assigned this May 12, 2015

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented May 12, 2015

Ooh, will be interesting to see.

Coolthulhu added a commit that referenced this pull request May 12, 2015

Merge pull request #12271 from jokermatt999/laundromat
Add Noodles of Doom's Laundromat

@Coolthulhu Coolthulhu merged commit 18dc7d9 into CleverRaven:master May 12, 2015

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.