Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazemod update #12431

Merged
merged 3 commits into from May 24, 2015

Conversation

Reviewers
No reviews
Assignees

@Coolthulhu Coolthulhu

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@chaosvolt @Coolthulhu @tyrael93 @DavidKeaton @BevapDin
@chaosvolt
Copy link
Contributor

commented May 21, 2015

http://smf.cataclysmdda.com/index.php?topic=8060.msg234106#msg234106

By all means, if someone could update it, please do.

Copypasta from the latest version of Vehicle Additions Pack from the
forum thread, should fix some turret install and/or load errors currently
present.
chaosvolt
Blazemod update 
1. Copypasta from the latest version of Vehicle Additions Pack from the
forum thread, should fix some turret install and load errors currently
present.
Loading status checks…
53b3111
@Coolthulhu

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented May 21, 2015

The "fuel_type" tag is outdated on weapons. This will require a big search+replace before merging.
Preferably on Blaze's side, so that he unclutters his mod for future updates (if he wants to keep updating it).
data/mods/blazemod/blaze_weapons_parts.json Outdated
@@ -115,6 +120,7 @@
"broken_color" : "dark_gray",
"damage_modifier" : 80,
"durability" : 400,
"fuel_type" : "50",

This comment has been minimized.

Sign in to view
Copy link
@BevapDin

BevapDin May 21, 2015

Contributor

A note about this: the game takes the ammo type now directly from the gun of the turret, putting it here as fuel type is not needed anymore. It is actually wrong because fuel types are item types, not ammo types (see #12411 for the reaching about this).

And a final note (you may have already done this), please go into the vehicle info and try to install a part and scroll through all listed item. This should not not give any debug messages. Listing an ammo type (which is not by chance also an item type) here will show a debug message.

In short: just remove the fuel_type entry from all parts with the TURRET flag (it is only required for parts with the FUEL_TANK or the ENGINE flag)
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented May 21, 2015

Blarghle. What's the equivalent tag now? Not sure whether to peaster Blaze to fix that or do it here myself. >w<

In short: just remove the fuel_type entry from all parts with the TURRET flag (it is only required for parts with the FUEL_TANK or the ENGINE flag)

Will do, I guess.
chaosvolt
Update 2 
1. Removal of fuel_type on turrets.
Loading status checks…
bbc3bf7
data/mods/blazemod/blaze_override.json
@@ -258,5 +258,24 @@
{"item": "steel_chunk", "min": 5, "max": 10},
{"item": "scrap", "min": 5, "max": 10}
]
},{

This comment has been minimized.

Sign in to view
Copy link
@Coolthulhu

Coolthulhu May 22, 2015

Contributor

Does this entry actually change anything from the usual battery mount? If not, it should be removed.
data/mods/blazemod/blaze_autoweapons.json Outdated
@@ -41,7 +41,7 @@
"price": 280000,
"material": ["steel", "plastic"],
"ammo_effects": ["BOUNCE", "LIGHTNING", "MOUNTED_GUN"],
"flags": ["NO_AMMO", "NEVER_JAMS", "NO_UNLOAD", "USE_UPS_200"],
"flags": ["NEVER_JAMS", "NO_UNLOAD", "USE_UPS_200"],

This comment has been minimized.

Sign in to view
Copy link
@BevapDin

BevapDin May 22, 2015

Contributor

The "USE_UPS_*" flags don't do anything anymore. The used UPS charges are defined directly as a member:

{
    "id": "ateslagun",
    "ups_charges": 200,

Hmm, seems I haven't properly updated that in all the mods when I changed it, I apologize.
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented May 22, 2015

I'm not entirely sure, but note that Blaze did upload an update to Mediafire. Gonna get it and commit it here, then see if it changed these added things.

EDIT: Yeah, Blaze corrected that already in the latest version on Mediafire, will commit soon.
chaosvolt
Update 3 
1. Copy-paste from the latest version of Blazemod from the forum
thread's link. Among other things, it seems to have fixed the UPS thing
BeVapDin mentioned.
Loading status checks…
e0c8f5c
@tyrael93

This comment has been minimized.

Sign in to view
Copy link

commented May 22, 2015

Are rocks still classified as ammo in this version?
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented May 23, 2015

Are rocks still classified as ammo in this version?

Seems to be the case, yes. The derpiness that causes has been discussed in an issue I opened, unsure if its flammability has been corrected. o3o

@Coolthulhu Coolthulhu self-assigned this May 24, 2015

Coolthulhu added a commit that referenced this pull request May 24, 2015

@Coolthulhu
Merge pull request #12431 from chaosvolt/blazemod-update 
Blazemod update
762a858

@Coolthulhu Coolthulhu merged commit 762a858 into CleverRaven:master May 24, 2015
1 check passed

1 check passed

default
Details
@DavidKeaton

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented May 24, 2015

glad this made it in!
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented May 24, 2015

Yus. Thank you Coolthulhu for the merge, and thanks to Blaze for letting me PR it. owo

@chaosvolt chaosvolt deleted the chaosvolt:blazemod-update branch May 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.